Date: Thu, 24 Mar 2005 12:02:10 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Stefan Farfeleder <stefan@fafoe.narf.at> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/linux linux_ioctl.c Message-ID: <20050324200210.GA26763@odin.ac.hmc.edu> In-Reply-To: <20050324194852.GJ46915@wombat.fafoe.narf.at> References: <200503241751.j2OHpFQg063306@repoman.freebsd.org> <200503241333.53622.jhb@FreeBSD.org> <20050324192502.GB7294@odin.ac.hmc.edu> <20050324194852.GJ46915@wombat.fafoe.narf.at>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Thu, Mar 24, 2005 at 08:48:53PM +0100, Stefan Farfeleder wrote: > On Thu, Mar 24, 2005 at 11:25:02AM -0800, Brooks Davis wrote: > > On Thu, Mar 24, 2005 at 01:33:53PM -0500, John Baldwin wrote: > > > On Thursday 24 March 2005 12:51 pm, Brooks Davis wrote: > > > > brooks 2005-03-24 17:51:15 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > sys/compat/linux linux_ioctl.c > > > > Log: > > > > Compile errors are way more useful then panics later. > > > > > > > > Replace a KASSERT of LINUX_IFNAMSIZ == IFNAMSIZ with a preprocessor > > > > check and #error message. This will prevent nasty suprises if users > > > > change IFNAMSIZ without updating the linux code appropriatly. > > > > > > There's a CTASSERT() macro that you can use for compile time assertions. > > > > Ah, intresting. It produces a less informative error, but I guess the > > fact that it should work on any C compiler makes up for it. I'll switch > > to that. > > Do you imply there's a C compiler which can't handle #if and #error? Prior to C99, I think #error wasn't specified. C99 does specify it. -- Brooks -- Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFCQxzBXY6L6fI4GtQRAr+cAKCq9Dm5o65x4rPL24x+NhaGjCPclwCg3Bkd 9Hq56JjTFSjUWTtwThFAcLY= =0JZK -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050324200210.GA26763>