Date: Mon, 3 Apr 2000 08:57:47 +0930 From: Greg Lehey <grog@lemis.com> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: Poul-Henning Kamp <phk@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: Danish axes (was: cvs commit: src/sys/alpha/alpha machdep.c src/sys/cam/scsi scsi_cd.c scsi_da.c scsi_pass.c scsi_pt.c scsi_sa.c scsi_target.c src/sys/contrib/dev/fla fla.c src/sys/contrib/softupdates ffs_softdep.c src/sys/dev/amr amr.c amr_disk.c src/sys/dev/ata ...) Message-ID: <20000403085747.B42140@freebie.lemis.com> In-Reply-To: <200004022318.QAA51365@apollo.backplane.com> References: <200004021524.IAA02434@freefall.freebsd.org> <20000403084250.A41843@freebie.lemis.com> <200004022318.QAA51365@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, 2 April 2000 at 16:18:16 -0700, Matthew Dillon wrote: >>> phk 2000/04/02 08:24:58 PDT >>> >>> sys/dev/vinum vinuminterrupt.c vinumio.c vinumraid5.c >>> vinumrequest.c vinumrevive.c >>> vnode_pager.c >>> Log: >>> Move B_ERROR flag to b_ioflags and call it BIO_ERROR. >>> >>> (Much of this done by script) >>> >>> Move B_ORDERED flag to b_ioflags and call it BIO_ORDERED. >>> >>> Move b_pblkno and b_iodone_chain to struct bio while we transition, they >>> will be obsoleted once bio structs chain/stack. >>> >>> Add bio_queue field for struct bio aware disksort. >> >> Is this another night of the Danish axes? You know that we have >> serious problems with Vinum already, and a number seem to stem from >> your last changes. You didn't even pass this by me. How do you >> expect me to fix anything when you keep moving the target? If you >> want to make these changes yourself, at least test the results and >> ensure that all known problems have been removed. >> >> I think we should add an item to the policy that changes of this >> magnitude should only be done with consensus. > > B_ERROR is extremely important to buffer cache processing - > specifically brelse(), it does NOT belong in the bio structure. It would be really good if you could come to an agreement with phk on this. It will cost me a lot more time to check this change, and if it's going to be backed out, I can save the trouble. Greg -- Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000403085747.B42140>