Date: Mon, 07 Nov 2022 12:15:14 +0100 From: Alexander Leidinger <Alexander@leidinger.net> To: Li-Wen Hsu <lwhsu@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script Message-ID: <20221107121514.Horde.nulS9Wg1s3yzAsXXkuJRBa9@webmail.leidinger.net> In-Reply-To: <202211070339.2A73dJlO027991@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format and has been PGP signed. --=_oy-tqzi5u_E8mvyoMqvqEaH Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Quoting Li-Wen Hsu <lwhsu@freebsd.org> (from Mon, 7 Nov 2022 03:39:19 GMT): > The branch main has been updated by lwhsu: > > URL:=20=20 >=20https://cgit.FreeBSD.org/src/commit/?id=3D72a1cb05cd230ce0d12a7180ae65d= dbba2e0cb6d > > commit 72a1cb05cd230ce0d12a7180ae65ddbba2e0cb6d > Author: Li-Wen Hsu <lwhsu@FreeBSD.org> > AuthorDate: 2022-11-07 03:30:09 +0000 > Commit: Li-Wen Hsu <lwhsu@FreeBSD.org> > CommitDate: 2022-11-07 03:30:09 +0000 > > rc(8): Add a zpoolupgrade rc.d script > > If a zpool is created by makefs(8), its version is 5000, i.e., all > feature flags are off. Introduce an rc script to run `zpool upgrade` > over the assigned zpools on the first boot. This is useful to the > ZFS based VM images built from release(7). > diff --git a/share/man/man5/rc.conf.5 b/share/man/man5/rc.conf.5 > index f9ceabc83120..43fa44a5f1cb 100644 > --- a/share/man/man5/rc.conf.5 > +++ b/share/man/man5/rc.conf.5 > @@ -24,7 +24,7 @@ > .\" > .\" $FreeBSD$ > .\" > -.Dd August 28, 2022 > +.Dd November 7, 2022 > .Dt RC.CONF 5 > .Os > .Sh NAME > @@ -2109,6 +2109,13 @@ A space-separated list of ZFS pool names for=20=20 >=20which new pool GUIDs should be > assigned upon first boot. > This is useful when using a ZFS pool copied from a template, such=20=20 >=20as a virtual > machine image. > +.It Va zpool_upgrade > +.Pq Vt str > +A space-separated list of ZFS pool names for which version should=20=20 >=20be upgraded > +upon first boot. > +This is useful when using a ZFS pool generated by > +.Xr makefs 8 > +utility. For someone who knows ZFS well, it is clear that only a zpool upgrade=20=20 is=20done. Not so experienced people may assume there is a combination=20= =20 of=20zpool upgrade and zfs upgrade (more so for people which do not know=20= =20 what=20the difference is). Maybe you want to add some explicit=20=20 documentation,=20that zfs upgrade + feature flags needs to be done by=20=20 hand. And=20this brings me to a second topic, we don't have an explicit list=20= =20 of=20features which are supported by the bootloader (I had a look at the=20= =20 zfs=20and the boot related man pages, if I overlooked a place, then the=20= =20 other=20places should reference this important part with some text). Bye, Alexander. --=20 http://www.Leidinger.net=20Alexander@Leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.org netchild@FreeBSD.org : PGP 0x8F31830F9F2772BF --=_oy-tqzi5u_E8mvyoMqvqEaH Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIzBAABCAAdFiEER9UlYXp1PSd08nWXEg2wmwP42IYFAmNo6MIACgkQEg2wmwP4 2IbJNBAAh3DGxNxUgXQB5028KYHm4A8H58o6alhWPLTc6aNfC43CZqNcKqJuWbsH 62tB/Vfje/diinkuKrx3DYsrSyn6dWQhFoqojpcfHDeOVlfdukksjOmR4Os6x8DL h2xCnz6KIOzLBjNzOu9ynsWxa+LixwyEusHhgybEq8BqG4uA7miMsYwyxlFMV+NY 1RYtL8rXyWk9uX6M9TvFu+Xzsg+umzKiDG93+dJZ9GUUbMzQKgwhnfrsszYS/pDB h3wNh+ZmxCc9efNB9iq+Wpas29ZpelqR6RThlpyTkNpxJ0UYg/p8YLoX85/gGPF+ ctRRue7NHAxtmvkPbX0CLU/AB8e9KeQ2MLfUgNz0DnESqBOdXMkPOVLvVtPZwWgx FresPImHmfCTyDZLZlA4eIglfrQEry5kO0Nu3BscmVhyUV3F1eYLFnT/3+b737yD gOHIHOswJkQMeHd6OQxISBWnl1+1EivHEY8Vu98RSAoGVyKtRX+GZ3DHgM9zcgW2 Cg7/OlcZxz+HJ4OUmJpmPLITSISZ5H6iBhBxt4NzaDRJs3Hd6Cnm9F1OfHumrTNa Wue34Lb2lGYtkj1Ewh++t3R6Hd3R9IR9WLDMNj5e4VSxelqpYjRW7KSiuA2Oog2D fIzrqEiGo+xVHjZgDMAssbBVmBFZM+/y93UDVOYThdlWjO62jCk= =alMg -----END PGP SIGNATURE----- --=_oy-tqzi5u_E8mvyoMqvqEaH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20221107121514.Horde.nulS9Wg1s3yzAsXXkuJRBa9>