Date: Wed, 11 Mar 2009 08:14:44 +0000 (UTC) From: Warner Losh <imp@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r189682 - head/sys/dev/pccard Message-ID: <200903110814.n2B8EiGV088733@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: imp Date: Wed Mar 11 08:14:44 2009 New Revision: 189682 URL: http://svn.freebsd.org/changeset/base/189682 Log: Allow zero length memroy space descriptor sections. It is apparently legal in the spec. Add newline to the verbose messages we print when debugging when this happens. The Hitachi HT-4840-11 is the only card to hit these in years, and it works well enough if we're liberal about what we accept. Modified: head/sys/dev/pccard/pccard_cis.c Modified: head/sys/dev/pccard/pccard_cis.c ============================================================================== --- head/sys/dev/pccard/pccard_cis.c Wed Mar 11 08:12:28 2009 (r189681) +++ head/sys/dev/pccard/pccard_cis.c Wed Mar 11 08:14:44 2009 (r189682) @@ -1198,8 +1198,7 @@ pccard_parse_cis_tuple(const struct pcca if (lengthsize == 0) { DPRINTF(("cfe memspace " - "lengthsize == 0")); - state->card->error++; + "lengthsize == 0\n")); } for (i = 0; i < cfe->num_memspace; i++) { if (lengthsize) { @@ -1211,9 +1210,8 @@ pccard_parse_cis_tuple(const struct pcca cfe->memspace[i].length = 0; } if (cfe->memspace[i].length == 0) { - DPRINTF(("cfe->memspace[%d].length == 0", + DPRINTF(("cfe->memspace[%d].length == 0\n", i)); - state->card->error++; } if (cardaddrsize) { cfe->memspace[i].cardaddr =
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200903110814.n2B8EiGV088733>