Date: Mon, 7 Nov 2022 20:23:33 -0800 From: Mark Millard <marklmi@yahoo.com> To: Ravi Pokala <rpokala@freebsd.org> Cc: Li-Wen Hsu <lwhsu@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: 3bf53c4c8f53 - main - release(7): Enable zpoolupgrade rc script in ZFS based VM images Message-ID: <4B38B373-B935-40FD-B1A2-AA85B6F5C9F1@yahoo.com> In-Reply-To: <6699F3B1-3CCB-4A03-A4EB-86D34ECD28BB@panasas.com> References: <202211070350.2A73oo64051412@gitrepo.freebsd.org> <9A7B38D3-9BC4-4B45-A71D-0604F7F4887A@panasas.com> <CAKBkRUwi4=tNhME57hW1mAPuTc9p288skZh3iCG2QktmYv1n-A@mail.gmail.com> <6699F3B1-3CCB-4A03-A4EB-86D34ECD28BB@panasas.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Nov 7, 2022, at 11:34, Ravi Pokala <rpokala@freebsd.org> wrote:
> -----Original Message-----
> From: Li-Wen Hsu <lwhsu@freebsd.org>
> Date: 2022-11-06, Sunday at 22:48
> To: Ravi Pokala <rpokala@freebsd.org>
> Cc: <src-committers@freebsd.org>, <dev-commits-src-all@freebsd.org>, =
<dev-commits-src-main@freebsd.org>
> Subject: Re: 3bf53c4c8f53 - main - release(7): Enable zpoolupgrade rc =
script in ZFS based VM images
>=20
> On Mon, Nov 7, 2022 at 1:33 PM Ravi Pokala <rpokala@freebsd.org> =
wrote:
>>=20
>> Hi Li-Wen,
>>=20
>> If I'm reading this (and 72a1cb05cd23) correctly, this will run =
`zpool upgrade' on the "zroot" pool on every boot. That's fine for the =
first time a VM image is used, since presumably the root pool and the =
bootloader were generated from the same sources. But if the root pool is =
subsequently upgraded by the running VM, don't we need to make sure the =
bootloader is also upgraded? Otherwise, don't we run into the =
possibility of this new `zpoolupgrade' script enabling features which =
are not supported by the bootloader?
>>=20
>> There should be some mechanism for upgrading the bootloader, or else =
something else that runs on the first boot from the VM image should =
disable `zpoolupgrade' so it is only run the first time.
>>=20
>> Thanks,
>>=20
>> Ravi (rpokala@)
>=20
> The zpoolupgrade rc script has "KEYWORD: firstboot" so it is only
> executed when the ${firstboot_sentinel} file exists, it works in =
the
> same way as growfs and zpoolreguid rc scripts. I've been thinking
> renaming these to firstboot_* as others provided by
> sysutils/firstboot-* from ports, but I think it's also fine to keep
> the consistency for now.
>=20
> Ah! I completely missed the 'firstboot' keyword. That sounds much =
better!
>=20
> That said, Mark Millard brought up a good point about only enabling =
features supported by RELEASE bootloaders.
>=20
> Thanks,
>=20
> Ravi (rpokala@)
Reviewing the zpool features, there is at least one for which:
"This feature becomes active as soon as it is enabled and will
never return to being enabled."
(or analogous). There are ones for which:
"READ-ONLY COMPATIBLE no"
Some have both statuses, for example, head_errlog.
However, the loader may do so little that its stage avoids
the general "READ-ONLY COMPATIBLE no" status for some
features.
=3D=3D=3D
Mark Millard
marklmi at yahoo.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B38B373-B935-40FD-B1A2-AA85B6F5C9F1>