Date: Wed, 19 Mar 2014 09:44:31 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Andrew Rybchenko <Andrew.Rybchenko@oktetlabs.ru> Cc: net@FreeBSD.org Subject: Re: [PATCH 1/6] sfxge: fix mbuf leak if it does not fit in software queue Message-ID: <20140319054431.GN1499@glebius.int.ru> In-Reply-To: <53292470.801@oktetlabs.ru> References: <53280DB3.4080900@oktetlabs.ru> <20140318124624.GD1499@FreeBSD.org> <53292470.801@oktetlabs.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 19, 2014 at 09:00:32AM +0400, Andrew Rybchenko wrote: A> Gleb, A> A> On 03/18/2014 04:46 PM, Gleb Smirnoff wrote: A> > Andrew, A> > A> > On Tue, Mar 18, 2014 at 01:11:15PM +0400, Andrew Rybchenko wrote: A> > A> A> > A> sfxge: fix mbuf leak if it does not fit in software queue A> > A> A> > A> mbuf should be owned by if_transmit function in any case. A> > A> A> > A> Submitted-by: Andrew Rybchenko <Andrew.Rybchenko@oktetlabs.ru> A> > A> Sponsored by: Solarflare Communications, Inc. A> > A> > Can we simplify the function while here? A> One of the next patches (4/6) moves link down check to the function and A> uses "fail" label to increment early drops statistics and free mbuf. A> IMHO, it is really nice to have single place to do it. I've replied to 4/6 and to 3/6 as well. Please consider my suggestions. If you insist on committing your patches as is, then please resubmit them as email attachments. When submitting them inlined, your MUA mangles patches, and they fail to apply. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140319054431.GN1499>