Date: Fri, 16 Jun 2023 17:05:19 -0300 From: Joseph Mingrone <jrm@FreeBSD.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: dev-commits-src-main@freebsd.org Subject: Re: git: 171a7bbfc048 - main - tcpdump: fix build with WITHOUT_PF=1 Message-ID: <865y7np400.fsf@phe.ftfl.ca> In-Reply-To: <ZIk7jOPhIE8jieR1@FreeBSD.org> (Gleb Smirnoff's message of "Tue, 13 Jun 2023 21:01:16 -0700") References: <202306140359.35E3x4fJ060841@gitrepo.freebsd.org> <ZIk7jOPhIE8jieR1@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hello Gleb, Thanks for reporting. https://reviews.freebsd.org/D40578 Joe On Tue, 2023-06-13 at 21:01, Gleb Smirnoff <glebius@freebsd.org> wrote: > Joseph, > I guess there is also regression with pfsync printing. Didn't check with > real traffic, but: > # grep pfsync_if_print * > grep: cmake: Is a directory > grep: doc: Is a directory > grep: lbl: Is a directory > grep: missing: Is a directory > netdissect.h:extern u_int pfsync_if_print(netdissect_options *, const str= uct pcap_pkthdr *, const u_char *); > print-pfsync.c:pfsync_if_print(netdissect_options *ndo, const struct pcap= _pkthdr *h, > # > Doesn't look used. > On Wed, Jun 14, 2023 at 03:59:04AM +0000, Gleb Smirnoff wrote: > T> The branch main has been updated by glebius: > T>=20 > T> URL: https://cgit.FreeBSD.org/src/commit/?id=3D171a7bbfc04885150401ab6= 4d96793373a8b2061 > T>=20 > T> commit 171a7bbfc04885150401ab64d96793373a8b2061 > T> Author: Gleb Smirnoff <glebius@FreeBSD.org> > T> AuthorDate: 2023-06-14 03:58:36 +0000 > T> Commit: Gleb Smirnoff <glebius@FreeBSD.org> > T> CommitDate: 2023-06-14 03:58:36 +0000 > T>=20 > T> tcpdump: fix build with WITHOUT_PF=3D1 > T>=20=20=20=20=20 > T> Fixes: ee67461e56828dd1f8de165947ba83f6d9148a87 > T> --- > T> contrib/tcpdump/print.c | 2 +- > T> 1 file changed, 1 insertion(+), 1 deletion(-) > T>=20 > T> diff --git a/contrib/tcpdump/print.c b/contrib/tcpdump/print.c > T> index 9c0ab8622de1..42a4548e8689 100644 > T> --- a/contrib/tcpdump/print.c > T> +++ b/contrib/tcpdump/print.c > T> @@ -185,7 +185,7 @@ static const struct printer printers[] =3D { > T> #ifdef DLT_LOOP > T> { null_if_print, DLT_LOOP }, > T> #endif > T> -#ifdef DLT_PFLOG > T> +#if defined(DLT_PFLOG) && defined(HAVE_NET_IF_PFLOG_H) > T> { pflog_if_print, DLT_PFLOG }, > T> #endif > T> #ifdef DLT_PKTAP --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKkBAEBCgCOFiEEVbCTpybDiFVxIrrVNqQMg7DW754FAmSMwH9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUQHGpybUBmcmVl YnNkLm9yZwAKCRA2pAyDsNbvnh3vD/0b9g75P0RCKMsYDatgcftCS46NqOpDpxmU wjVmc2CLE59cD0QiHjPe6MXpRvvJEip1iCFUj9W6P5NR71qaVVzNGc2J49UVcz1d 61sSb58AKcmaWM62FfrK6xeYxRL5z5Skag647T5oXWvksp7HPX+NmProseTp4wY7 GI8KsZJgLXwI9YGda3iDK1eJ15OLduq5C6z4c7/8mRUUye1PiTwCgub3NCJkswd2 kZv5o2PERpFR4L2/jq/ep0x+tSjbjDybHBA3v1EOIBrI9I6kzp2m4679UOSxwNXR faadMGW9Eh5phGJt5El4IWEjhgs7w/SEHL0/wzfMMvXrzrK5u13m7jTHHg16LscB Gt73qlQeW9Y1Kx9pNQ1cM631UoiYNP5V5gg/y6cwaVUpqQdVKBaqch7kZ3rLtpLn i4KDZB0zeWbOxf42KkN77rsJDfk6lDt6f+weX2FvyF8s40b5TTnMGZl4YDVnTp33 k3UzibllxmhDHkhnMclMU9mCLkhCXEgcC/kwt7aJVvXceiUfZQgG9jMljEkknfLu sPjmfaHPuUojjXmK7Z6qGJEOQKw57cjaS34+Ul31YsRIM+e+bMRRwHCB44cJoQAq CQpf+7I6paQgeW1AVFTljDU4lCIG0NFtzY1KqWroXBuoP3GTKQKkOCL7WvvD8Rvr ru1aHSKHoQ== =ZgOJ -----END PGP SIGNATURE----- --=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?865y7np400.fsf>