Date: Sat, 21 Sep 2024 13:13:48 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org> To: Konstantin Belousov <kib@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: a52b30ff98cd - main - sys_pipe: consistently use cr_ruidinfo for accounting of pipebuf Message-ID: <867cb5z2c3.fsf@ltc.des.dev> In-Reply-To: <202409202109.48KL9RZ1078677@gitrepo.freebsd.org> (Konstantin Belousov's message of "Fri, 20 Sep 2024 21:09:27 GMT") References: <202409202109.48KL9RZ1078677@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
Konstantin Belousov <kib@FreeBSD.org> writes:
> commit a52b30ff98cdab82af140285fa7fcdf1036fef27
> Author: Konstantin Belousov <kib@FreeBSD.org>
> AuthorDate: 2024-09-20 18:48:19 +0000
> Commit: Konstantin Belousov <kib@FreeBSD.org>
> CommitDate: 2024-09-20 21:08:51 +0000
>
> sys_pipe: consistently use cr_ruidinfo for accounting of pipebuf
>
> Tested by: yasu
> Sponsored by: The FreeBSD Foundation
> MFC after: 1 week
> ---
> sys/kern/sys_pipe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sys/kern/sys_pipe.c b/sys/kern/sys_pipe.c
> index 2b81d08f7077..6a5d150423bc 100644
> --- a/sys/kern/sys_pipe.c
> +++ b/sys/kern/sys_pipe.c
> @@ -1677,7 +1677,7 @@ pipe_free_kmem(struct pipe *cpipe)
>
> if (cpipe->pipe_buffer.buffer != NULL) {
> atomic_subtract_long(&amountpipekva, cpipe->pipe_buffer.size);
> - chgpipecnt(cpipe->pipe_pair->pp_owner->cr_uidinfo,
> + chgpipecnt(cpipe->pipe_pair->pp_owner->cr_ruidinfo,
> -cpipe->pipe_buffer.size, 0);
> vm_map_remove(pipe_map,
> (vm_offset_t)cpipe->pipe_buffer.buffer,
This appears to be the opposite of the patch which you posted on
-current and which yasu@ tested (minus the bit that you committed as
af96ccc6a508). That patch replaced cr_ruidinfo with cr_uidinfo in three
places; this patch replaces cr_uidinfo with cr_ruidinfo somewhere else.
DES
--
Dag-Erling Smørgrav - des@FreeBSD.org
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?867cb5z2c3.fsf>