Date: Fri, 24 May 2024 00:22:40 +0000 From: Brooks Davis <brooks@freebsd.org> To: Lexi Winter <lexi@le-fay.org> Cc: Mariusz Zaborski <oshogbo@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 408957613bc0 - main - Regen Message-ID: <Zk_d0AkjfcwjDmoV@spindle.one-eyed-alien.net> In-Reply-To: <Zk_a3GLevuNFS680@ilythia.eden.le-fay.org> References: <202405212004.44LK4cBG042804@gitrepo.freebsd.org> <Zk2lBymRapenk_V8@ilythia.eden.le-fay.org> <Zk4lyti6kSjAux1t@spindle.one-eyed-alien.net> <Zk_a3GLevuNFS680@ilythia.eden.le-fay.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 24, 2024 at 01:10:04AM +0100, Lexi Winter wrote: > Brooks Davis: > > This is more or less standard practice for generated files. These > > commits are of basically no interest. > > to be clear, i'm certainly not expecting a detailed commit message for > things like this. my only concern is that when viewing the commit log > for all of src/, or for src/sys/ or whatever, they look like this: > > 8e4b8e9d807aa379d2a1c3aaac2537ba7d6bf0bf LinuxKPI: add kvmemdup() > 69b6c4a6ec6654978628ccd48edce46f00ac3e96 LinuxKPI: 802.11: fix for_each_sta_active_link() > 408957613bc065c4444812c3ae276ace03697ebd Regen > 6b7e4254a29e3228a7273622556b60416e300509 capsicum: allow rfork(2) in capability mode > c80c104cbd52db994c0f2757bd1c6d014744022c glabel.8: Describe cases related to permissions / existing mounts > > the other commits make it clear what they touch (LinuxKPI, capsicum, > ...) so i can ignore those if that's not what i'm looking for, but > 'Regen' is not very informative there. if it just included the filename > it would immediately be much more helpful. It should probably contains "sysent: ". It's pretty rare that one file is touched (usually that's an error). -- Brooks
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Zk_d0AkjfcwjDmoV>