Date: Mon, 16 Sep 2013 15:42:14 +0300 From: Alexander Motin <mav@FreeBSD.org> To: Ivan Voras <ivoras@freebsd.org> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-9@freebsd.org Subject: Re: svn commit: r255567 - stable/9/sys/geom/zero Message-ID: <5236FCA6.6070106@FreeBSD.org> In-Reply-To: <CAF-QHFWGcFdaHtJDCDLy7LtDcG=EB%2B05JUcOkT63FBbKXSLPug@mail.gmail.com> References: <201309141012.r8EACTW9032484@svn.freebsd.org> <CAF-QHFWGcFdaHtJDCDLy7LtDcG=EB%2B05JUcOkT63FBbKXSLPug@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16.09.2013 15:20, Ivan Voras wrote: > On 14 September 2013 12:12, Alexander Motin <mav@freebsd.org> wrote: > >> Add unmapped BIO support to GEOM ZERO if kern.geom.zero.clear is cleared. > >> + if (g_zero_clear && (bp->bio_flags & BIO_UNMAPPED) == 0) >> memset(bp->bio_data, g_zero_byte, bp->bio_length); > > > Umm, I might be wrong, but won't this basically export random kernel > memory to anyone reading from /dev/gzero? I may be wrong, but I think it won't. Buffer for reading is provided by the caller, mapped to KVA and then unmapped back without modifications. If there was some garbage in the buffer, it will remain there, but that is a caller's garbage. There may be exceptions in case of of gstripe and graid3 that allocate own buffers I am not sure they clean before use, but do you know many people using graid3 on top of gzero? -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5236FCA6.6070106>