Date: Mon, 16 May 2016 17:20:38 -0700 From: Ngie Cooper <yaneurabeya@gmail.com> To: "Simon J. Gerraty" <sjg@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r299995 - head/usr.bin/kdump Message-ID: <CAGHfRMAZM5qzpew1f_Y47KALru=jk9=XH70%2BFuVA_pM6bgt9Hg@mail.gmail.com> In-Reply-To: <201605170008.u4H08hEB098976@repo.freebsd.org> References: <201605170008.u4H08hEB098976@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 16, 2016 at 5:08 PM, Simon J. Gerraty <sjg@freebsd.org> wrote: > Author: sjg > Date: Tue May 17 00:08:43 2016 > New Revision: 299995 > URL: https://svnweb.freebsd.org/changeset/base/299995 > > Log: > Allow -f - to read from stdin. > > Modified: > head/usr.bin/kdump/kdump.c > > Modified: head/usr.bin/kdump/kdump.c > ============================================================================== > --- head/usr.bin/kdump/kdump.c Tue May 17 00:00:01 2016 (r299994) > +++ head/usr.bin/kdump/kdump.c Tue May 17 00:08:43 2016 (r299995) > @@ -298,8 +298,9 @@ main(int argc, char *argv[]) > m = malloc(size = 1025); > if (m == NULL) > errx(1, "%s", strerror(ENOMEM)); > - if (!freopen(tracefile, "r", stdin)) > - err(1, "%s", tracefile); > + if (strcmp(tracefile, "-")) Please use `!= 0` for explicitness. Thanks, -Ngie
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMAZM5qzpew1f_Y47KALru=jk9=XH70%2BFuVA_pM6bgt9Hg>