Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 03 Oct 2014 11:23:24 -0600
From:      Ian Lepore <ian@FreeBSD.org>
To:        araujo@FreeBSD.org
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Bryan Drewery <bdrewery@freebsd.org>
Subject:   Re: svn commit: r272467 - in head/sys: cddl/contrib/opensolaris/uts/common/fs/zfs fs/nfs fs/nfsserver
Message-ID:  <1412357004.12052.86.camel@revolution.hippie.lan>
In-Reply-To: <CAOfEmZidQ724RrEPB6taOfoUNeXn2idTtKsXuM7DYgLoKx-BLg@mail.gmail.com>
References:  <201410030224.s932OfSw059966@svn.freebsd.org> <542ED903.30808@FreeBSD.org> <CAOfEmZidQ724RrEPB6taOfoUNeXn2idTtKsXuM7DYgLoKx-BLg@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 2014-10-04 at 01:17 +0800, Marcelo Araujo wrote:
> Hey,
> 
> Yes I have, you could check here: https://reviews.freebsd.org/D798
> 
> I should added the phabric on the commit log. My bad!
> 

IMO, no amount of verbiage in phabricator linked to from a commit
message is a substitute for a proper detailed commit message.

-- Ian

> Best Regards,
> On Oct 4, 2014 1:12 AM, "Bryan Drewery" <bdrewery@freebsd.org> wrote:
> 
> > On 10/2/2014 9:24 PM, Marcelo Araujo wrote:
> > > Author: araujo (ports committer)
> > > Date: Fri Oct  3 02:24:41 2014
> > > New Revision: 272467
> > > URL: https://svnweb.freebsd.org/changeset/base/272467
> > >
> > > Log:
> > >   Fix failures and warnings reported by newpynfs20090424 test tool.
> > >   This fix addresses only issues with the pynfs reports, none of these
> > >   issues are know to create problems for extant real clients.
> >
> > Do you have more details than "fix bugs"? :)
> >
> > Even which failures were fixed would be helpful to document.
> >
> > >
> > >   Submitted by:       Bart Hsiao <bart.hsiao@gmail.com>
> > >   Reworked by:        myself
> > >   Reviewed by:        rmacklem
> > >   Approved by:        rmacklem
> > >   Sponsored by:       QNAP Systems Inc.
> > >
> >
> >
> > --
> > Regards,
> > Bryan Drewery
> >
> >





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1412357004.12052.86.camel>