Date: Tue, 06 May 2014 03:08:32 +0400 From: Andrey Chernov <ache@freebsd.org> To: David Chisnall <theraven@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Pedro Giffuni <pfg@FreeBSD.org>, src-committers <src-committers@freebsd.org>, Warner Losh <imp@bsdimp.com> Subject: Re: svn commit: r265367 - head/lib/libc/regex Message-ID: <536819F0.1090507@freebsd.org> In-Reply-To: <5368162A.9000002@freebsd.org> References: <201405051641.s45GfFje086423@svn.freebsd.org> <5367CD77.40909@freebsd.org> <B11B5B25-8E05-4225-93D5-3A607332F19A@FreeBSD.org> <5367EB54.1080109@FreeBSD.org> <3C7CFFB7-5C84-4AC1-9A81-C718D184E87B@FreeBSD.org> <7D7A417E-17C3-4001-8E79-0B57636A70E1@gmail.com> <A4B5E0E8-93CB-4E80-9065-5D25A007B726@FreeBSD.org> <536807D8.9000005@freebsd.org> <9349EAA9-F92C-4170-A1C0-2200FD490E5F@FreeBSD.org> <5368162A.9000002@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 06.05.2014 2:52, Andrey Chernov wrote: > As I mention initially, literal enough checks is what we need to make > logic clear. In the case we discuss realloc() can be changed by > reallocf() which does n*size and NULL checks and literal "if" should be > added before malloc() to check overflow. Sorry crumpled phrase. Literal "if" for overflow checking should be added before both malloc() and reallocf(). Other ways will make the code obscure for human and hard to support. -- http://ache.vniz.net/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?536819F0.1090507>