Date: Sun, 10 Sep 2023 20:46:58 -0400 From: Alexander Motin <mav@FreeBSD.org> To: Mark Millard <marklmi@yahoo.com>, Martin Matuska <mm@FreeBSD.org>, Glen Barber <gjb@FreeBSD.org> Cc: Current FreeBSD <freebsd-current@freebsd.org>, FreeBSD-STABLE Mailing List <freebsd-stable@freebsd.org>, Pawel Jakub Dawidek <pjd@freebsd.org> Subject: Re: main [and, likely, stable/14]: do not set vfs.zfs.bclone_enabled=1 with that zpool feature enabled because it still leads to panics Message-ID: <a7e2726b-6a85-8083-41c0-f0c39d43481c@FreeBSD.org> In-Reply-To: <1B343698-6865-4761-B514-1539AAE291BC@yahoo.com> References: <7CE2CAAF-8BB0-4422-B194-4A6B0A4BC12C@yahoo.com> <08B7E72B-78F1-4ACA-B09D-E8C34BCE2335@yahoo.com> <20230907184823.GC4090@FreeBSD.org> <F4ED7034-6776-402C-8706-DED08F41455E@yahoo.com> <4f4e2b68-57e0-a475-e2bd-1f2b8844ebfe@FreeBSD.org> <354C5B8C-4216-4171-B8C2-8E827817F8E5@yahoo.com> <8B8B3707-4B37-4621-8124-D6A77CAF6879@yahoo.com> <15df58d3-4603-132f-112e-d10a6d4419bf@FreeBSD.org> <2a25427c-5a61-3f72-4e31-b7666741d38d@FreeBSD.org> <63717d32-f340-1320-3335-85135d1b62bc@FreeBSD.org> <05C47E15-640D-41AD-9C4C-73A1D5041CF4@yahoo.com> <A906A64F-3CAF-49E4-9C11-1A188FD22881@yahoo.com> <8746A218-F83A-40E7-95F8-5EC1E36411C1@yahoo.com> <1B343698-6865-4761-B514-1539AAE291BC@yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09.09.2023 12:32, Mark Millard wrote: > On Sep 8, 2023, at 21:54, Mark Millard <marklmi@yahoo.com> wrote: >> On Sep 8, 2023, at 18:19, Mark Millard <marklmi@yahoo.com> wrote: >>> On Sep 8, 2023, at 17:03, Mark Millard <marklmi@yahoo.com> wrote: >>>> On Sep 8, 2023, at 15:30, Martin Matuska <mm@FreeBSD.org> wrote: >>>> On 9. 9. 2023 0:09, Alexander Motin wrote: >>>>> Thank you, Martin. I was able to reproduce the issue with your script and found the cause. >>>>> >>>>> I first though the issue is triggered by the `cp`, but it appeared to be triggered by `cat`. It also got copy_file_range() support, but later than `cp`. That is probably why it slipped through testing. This patch fixes it for me: https://github.com/openzfs/zfs/pull/15251 . >>>>> >>>>> Mark, could you please try the patch? > > I finally stopped it at 7473 built (a little over 13 hrs elapsed): > > ^C[13:08:30] Error: Signal SIGINT caught, cleaning up and exiting > [main-amd64-bulk_a-default] [2023-09-08_19h51m52s] [sigint:] Queued: 34588 Built: 7473 Failed: 23 Skipped: 798 Ignored: 335 Fetched: 0 Tobuild: 25959 Time: 13:08:26 > [13:08:30] Logs: /usr/local/poudriere/data/logs/bulk/main-amd64-bulk_a-default/2023-09-08_19h51m52s > [13:08:31] Cleaning up > [13:17:10] Unmounting file systems > Exiting with status 1 > > In part that was more evidence for deadlocks at least being fairly > rare as well. > > None of the failed ones looked odd. (A fair portion are because the > bulk -a was mostly doing WITH_DEBUG= builds. Many upstreams change > library names, some other file names, or paths used for debug > builds and ports generally do not cover well building the debug > builds for such. I've used these runs to extend my list of > exceptions that avoid using WITH_DEBUG .) So no evidence of > corruptions. Thank you, Mark. The patch was accepted upstream and merged to both master and zfs-2.2-release branches. -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a7e2726b-6a85-8083-41c0-f0c39d43481c>