Date: Tue, 25 Feb 2003 23:41:02 -0800 (PST) From: Julian Elischer <julian@elischer.org> To: Bill Paul <wpaul@FreeBSD.org> Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netgraph ng_fec.c Message-ID: <Pine.BSF.4.21.0302252331450.78515-100000@InterJet.elischer.org> In-Reply-To: <200302260638.h1Q6cs15050045@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 25 Feb 2003, Bill Paul wrote: > wpaul 2003/02/25 22:38:54 PST > > Modified files: > sys/netgraph ng_fec.c > Log: > Attempt to make the ng_fec module play nice with BPF again. Things have > changed since this code was written: > > - The ng_ether_input_p hook only accepts two arguments now: the pointer > to the ether header structure is gone. The problem is that you should not be using ng_ether_input_p at all that is a private interface between ng_ether.c and if_ethersubr.c. You should be connecting a hook to ng_ether.c which will in turn use ng_ether_input_p. I have on my list (right after my real job(TM) and kernel threading and some netgraph cleanups) to alter ng_fec to use the official interface. i.e. yu should be able to say: ngctl fxp0: mkpeer fec lower lower1 ngctl name fxp0:lower fec1 ngctl fxp1: connect fec1: lower lower2 ngctl fxp0: connect fec1: upper upper and hook an fec module onto two ethernet interfaces. (using fxp0 as the upper end) as it is, having ng_fec loaded in the kernel produces an instant coredump if ng_ether is also loaded as they fight over ng_ether's private hook into the ethernet code. As I said.. It's on my list .. but don't hold your breath. > > - It's no longer necessary to cons up a fake ether header before passing > incoming packets to BPF_MTAP(). > > ng_fec_input() has been modified to account for these two changes. > Running tcpdump on fec0 should work now. > > PR: kern/46720 > > Revision Changes Path > 1.4 +6 -16 src/sys/netgraph/ng_fec.c > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0302252331450.78515-100000>