Date: Wed, 03 Jul 2024 00:35:22 +0200 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Vladimir Druzenko <vvd@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 51ebcb95f10d - main - japanese/skkinput: Remove invalid option Message-ID: <f5491637ccbc8b0b8edc7eb93c6408b4@mail.infomaniak.com> In-Reply-To: <202407022227.462MRPeF034802@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 2024-07-03T00:27:25.000+02:00, Vladimir Druzenko <vvd@FreeBSD.org> wrote: > The branch main has been updated by vvd: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=51ebcb95f10d11c6a432f174424b866ff557b5dc > > commit 51ebcb95f10d11c6a432f174424b866ff557b5dc > > Author: mew14930xvi <mew14930xvi@inbox.lv> > > AuthorDate: 2024-07-02 22:11:50 +0000 > > Commit: Vladimir Druzenko <vvd@FreeBSD.org> > > CommitDate: 2024-07-02 22:26:16 +0000 > > japanese/skkinput: Remove invalid option > > > > Remove RSKKSERV option (Depends on japanese/rskkserv expired in 2014-09) > > Add LICENSE_FILE > > Add japanese/skkserv option > > If not selected in the options, do not install dictionary server > > Switch post-install to post-install-DOCS-on > > > > PR: 279374 > > Approved by: koma2@lovepeers.org (maintainer, timeout > 1 month) > > --- > > japanese/skkinput/Makefile | 31 +++++++++++++------------------ > > 1 file changed, 13 insertions(+), 18 deletions(-) > > diff --git a/japanese/skkinput/Makefile b/japanese/skkinput/Makefile > > index 58c03328d5e6..27305c5a9c13 100644 > > --- a/japanese/skkinput/Makefile > > +++ b/japanese/skkinput/Makefile > > @@ -1,6 +1,6 @@ > > PORTNAME= skkinput > > PORTVERSION= 2.06.4 > > -PORTREVISION= 3 > > +PORTREVISION= 4 > > CATEGORIES= japanese x11 > > MASTER_SITES= OSDN/skkinput2 > > > > @@ -8,7 +8,8 @@ MAINTAINER= koma2@lovepeers.org > > COMMENT= SKK-like Japanese input method for X11 > > WWW= http://skkinput2.sourceforge.jp/ > > > > -LICENSE= GPLv2 > > +LICENSE= GPLv2+ > > +LICENSE_FILE= ${WRKSRC}/GPL > > > > USES= imake xorg > > USE_XORG= ice sm x11 xext xt xmu > > @@ -17,24 +18,18 @@ PLIST_FILES= bin/skkinput lib/X11/app-defaults/Skkinput \ > > share/man/ja/man1/skkinput.1.gz share/man/man1/skkinput.1.gz > > PORTDOCS= *.jis ChangeLog skkinputlisp.doc dot.skkinput > > > > -OPTIONS_DEFINE= DOCS > > -OPTIONS_RADIO= SKKSERVER > > -OPTIONS_RADIO_SKKSERVER=DBSKKD RSKKSERV > > -SKKSERVER_DESC= Skkserver selection > > -DBSKKD_DESC= Use ja-dbskkd-cdb as skkserver > > -RSKKSERV_DESC= Use ja-rskkserv as skkserver > > +OPTIONS_DEFINE= DOCS > > +OPTIONS_DEFAULT= SKK9 > > +OPTIONS_RADIO= SKKSERVER > > +OPTIONS_RADIO_SKKSERVER= DBSKKD SKK9 > > +DBSKKD_DESC= Use ja-dbskkd-cdb as skkserver > > +SKK9_DESC= Use ja-skkserv as skkserver > > +SKKSERVER_DESC= Skkserver selection > > > > -.include <bsd.port.options.mk> [http://bsd.port.options.mk>]; > > +DBSKKD_RUN_DEPENDS= ${LOCALBASE}/libexec/dbskkd-cdb:japanese/dbskkd-cdb > > +SKK9_RUN_DEPENDS= ${LOCALBASE}/sbin/skkserv:japanese/skkserv > > > > -.if ${PORT_OPTIONS:MDBSKKD} > > -RUN_DEPENDS= ${LOCALBASE}/libexec/dbskkd-cdb:japanese/dbskkd-cdb > > -.elif ${PORT_OPTIONS:MRSKKSERV} > > -RUN_DEPENDS= ${LOCALBASE}/libexec/rskkserv:japanese/rskkserv > > -.else > > -RUN_DEPENDS= ${LOCALBASE}/sbin/skkserv:japanese/skkserv > > -.endif > > - > > -post-install: > > +post-install-DOCS-on: > > @${MKDIR} ${STAGEDIR}${DOCSDIR} > > # One of the docfiles lives in its own subdirectory; link it relative to > > # ${WRKSRC} to simplify installation routine (install all files at once) Hi, Please use a better describing short commit message as a lot more is changed than just removing an option. This is also true to the other skkinput port. Best regards, Daniel [-- Attachment #2 --] <html><body><div>On 2024-07-03T00:27:25.000+02:00, Vladimir Druzenko <vvd@FreeBSD.org> wrote:<br></div><div ><div><br></div></div><div><br></div><div class="ik_mail_quote answerContentMessage"><blockquote class="ws-ng-quote"><pre style="white-space: normal;"><div>The branch main has been updated by vvd:<br></div><div><br></div><div>URL: <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://cgit.FreeBSD.org/ports/commit/?id=51ebcb95f10d11c6a432f174424b866ff557b5dc" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=51ebcb95f10d11c6a432f174424b866ff557b5dc</a><br></div><div><br></div><div>commit 51ebcb95f10d11c6a432f174424b866ff557b5dc<br></div><div>Author: mew14930xvi <<a class="defaultMailLink" href="mailto:mew14930xvi@inbox.lv">mew14930xvi@inbox.lv</a>><br></div><div>AuthorDate: 2024-07-02 22:11:50 +0000<br></div><div>Commit: Vladimir Druzenko <<a class="defaultMailLink" href="mailto:vvd@FreeBSD.org">vvd@FreeBSD.org</a>><br></div><div>CommitDate: 2024-07-02 22:26:16 +0000<br></div><div><br></div><div> japanese/skkinput: Remove invalid option<br></div><div> <br></div><div> Remove RSKKSERV option (Depends on japanese/rskkserv expired in 2014-09)<br></div><div> Add LICENSE_FILE<br></div><div> Add japanese/skkserv option<br></div><div> If not selected in the options, do not install dictionary server<br></div><div> Switch post-install to post-install-DOCS-on<br></div><div> <br></div><div> PR: 279374<br></div><div> Approved by: <a class="defaultMailLink" href="mailto:koma2@lovepeers.org">koma2@lovepeers.org</a> (maintainer, timeout > 1 month)<br></div><div>---<br></div><div> japanese/skkinput/Makefile | 31 +++++++++++++------------------<br></div><div> 1 file changed, 13 insertions(+), 18 deletions(-)<br></div><div><br></div><div>diff --git a/japanese/skkinput/Makefile b/japanese/skkinput/Makefile<br></div><div>index 58c03328d5e6..27305c5a9c13 100644<br></div><div>--- a/japanese/skkinput/Makefile<br></div><div>+++ b/japanese/skkinput/Makefile<br></div><div>@@ -1,6 +1,6 @@<br></div><div> PORTNAME= skkinput<br></div><div> PORTVERSION= 2.06.4<br></div><div>-PORTREVISION= 3<br></div><div>+PORTREVISION= 4<br></div><div> CATEGORIES= japanese x11<br></div><div> MASTER_SITES= OSDN/skkinput2<br></div><div> <br></div><div>@@ -8,7 +8,8 @@ MAINTAINER= <a class="defaultMailLink" href="mailto:koma2@lovepeers.org">koma2@lovepeers.org</a><br></div><div> COMMENT= SKK-like Japanese input method for X11<br></div><div> WWW= <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://skkinput2.sourceforge.jp/" target="_blank">http://skkinput2.sourceforge.jp/</a><br></div><div>; <br></div><div>-LICENSE= GPLv2<br></div><div>+LICENSE= GPLv2+<br></div><div>+LICENSE_FILE= ${WRKSRC}/GPL<br></div><div> <br></div><div> USES= imake xorg<br></div><div> USE_XORG= ice sm x11 xext xt xmu<br></div><div>@@ -17,24 +18,18 @@ PLIST_FILES= bin/skkinput lib/X11/app-defaults/Skkinput \<br></div><div> share/man/ja/man1/skkinput.1.gz share/man/man1/skkinput.1.gz<br></div><div> PORTDOCS= *.jis ChangeLog skkinputlisp.doc dot.skkinput<br></div><div> <br></div><div>-OPTIONS_DEFINE= DOCS<br></div><div>-OPTIONS_RADIO= SKKSERVER<br></div><div>-OPTIONS_RADIO_SKKSERVER=DBSKKD RSKKSERV<br></div><div>-SKKSERVER_DESC= Skkserver selection<br></div><div>-DBSKKD_DESC= Use ja-dbskkd-cdb as skkserver<br></div><div>-RSKKSERV_DESC= Use ja-rskkserv as skkserver<br></div><div>+OPTIONS_DEFINE= DOCS<br></div><div>+OPTIONS_DEFAULT= SKK9<br></div><div>+OPTIONS_RADIO= SKKSERVER<br></div><div>+OPTIONS_RADIO_SKKSERVER= DBSKKD SKK9<br></div><div>+DBSKKD_DESC= Use ja-dbskkd-cdb as skkserver<br></div><div>+SKK9_DESC= Use ja-skkserv as skkserver<br></div><div>+SKKSERVER_DESC= Skkserver selection<br></div><div> <br></div><div>-.include <<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://bsd.port.options.mk>" target="_blank">bsd.port.options.mk></a>;<br></div><div>+DBSKKD_RUN_DEPENDS= ${LOCALBASE}/libexec/dbskkd-cdb:japanese/dbskkd-cdb<br></div><div>+SKK9_RUN_DEPENDS= ${LOCALBASE}/sbin/skkserv:japanese/skkserv<br></div><div> <br></div><div>-.if ${PORT_OPTIONS:MDBSKKD}<br></div><div>-RUN_DEPENDS= ${LOCALBASE}/libexec/dbskkd-cdb:japanese/dbskkd-cdb<br></div><div>-.elif ${PORT_OPTIONS:MRSKKSERV}<br></div><div>-RUN_DEPENDS= ${LOCALBASE}/libexec/rskkserv:japanese/rskkserv<br></div><div>-.else<br></div><div>-RUN_DEPENDS= ${LOCALBASE}/sbin/skkserv:japanese/skkserv<br></div><div>-.endif<br></div><div>-<br></div><div>-post-install:<br></div><div>+post-install-DOCS-on:<br></div><div> @${MKDIR} ${STAGEDIR}${DOCSDIR}<br></div><div> # One of the docfiles lives in its own subdirectory; link it relative to<br></div><div> # ${WRKSRC} to simplify installation routine (install all files at once)<br></div></pre></blockquote></div><div>Hi,<br></div><div><br></div><div>Please use a better describing short commit message as a lot more is changed than just removing an option. This is also true to the other skkinput port.<br></div><div><br></div><div>Best regards,<br></div><div>Daniel<br></div></body></html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f5491637ccbc8b0b8edc7eb93c6408b4>