Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 4 Mar 2002 16:04:02 -0800 (PST)
From:      Matthew Dillon <dillon@apollo.backplane.com>
To:        "Jan L. Peterson" <jlp@softhome.net>, Ian Dowse <iedowse@maths.tcd.ie>, freebsd-stable@FreeBSD.ORG
Subject:   Re: crashes on 4.5-RELEASE 
Message-ID:  <200203050004.g25042F91389@apollo.backplane.com>
References:  <200202232021.aa04276@salmon.maths.tcd.ie> <20020304233509.5BFD0422D8@mail.flipdog.com> 

next in thread | previous in thread | raw e-mail | index | archive | help

::So what exactly does INVARIANTS do?  According to LINT, it enables 
::extra sanity checking of internal structures (making the system 
::slower).  
::
::Seems to be a lot of people reporting crashing problems on 4.5, even on 
::hardware that was previously stable.  Could be we have a real problem 
::here?
::
::	-jan-

    There are no solid leads on that yet.

    Recently a commit to -current fixed a problem with NFS potentially
    building up huge socket buffers.  I wonder if this could be related
    and would like you to apply this patch to -stable and re-test if you
    could.

					-Matt
					Matthew Dillon 
					<dillon@backplane.com>

Index: uipc_socket.c
===================================================================
RCS file: /home/ncvs/src/sys/kern/uipc_socket.c,v
retrieving revision 1.68.2.18
diff -u -r1.68.2.18 uipc_socket.c
--- uipc_socket.c	13 Feb 2002 00:43:10 -0000	1.68.2.18
+++ uipc_socket.c	5 Mar 2002 00:02:59 -0000
@@ -525,7 +525,7 @@
 		if ((atomic && resid > so->so_snd.sb_hiwat) ||
 		    clen > so->so_snd.sb_hiwat)
 			snderr(EMSGSIZE);
-		if (space < resid + clen && uio &&
+		if (space < resid + clen &&
 		    (atomic || space < so->so_snd.sb_lowat || space < clen)) {
 			if (so->so_state & SS_NBIO)
 				snderr(EWOULDBLOCK);

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200203050004.g25042F91389>