Date: Fri, 3 Jan 2020 00:35:51 +0000 From: Brooks Davis <brooks@freebsd.org> To: Kyle Evans <kevans@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r355936 - in head/sys: arm/broadcom/bcm2835 arm/freescale/imx arm/ti/am335x arm/versatile powerpc/ofw Message-ID: <20200103003551.GH91104@spindle.one-eyed-alien.net> In-Reply-To: <CACNAnaFv=DDViZx36SeMoyBWW8BwDn4N5ekU7YVwsF-12t%2BCcw@mail.gmail.com> References: <201912201622.xBKGMEdl019516@repo.freebsd.org> <CACNAnaFv=DDViZx36SeMoyBWW8BwDn4N5ekU7YVwsF-12t%2BCcw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--x+6KMIRAuhnl3hBn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 23, 2019 at 03:14:07PM -0600, Kyle Evans wrote: > On Fri, Dec 20, 2019 at 10:22 AM Kyle Evans <kevans@freebsd.org> wrote: > > > > Author: kevans > > Date: Fri Dec 20 16:22:14 2019 > > New Revision: 355936 > > URL: https://svnweb.freebsd.org/changeset/base/355936 > > > > Log: > > Kill off dummy kbd drivers > > > > As far as I can tell, these are an artifact of times when linker sets > > couldn't be empty, otherwise the kernel build would fail due to unres= olved > > symbols. hselasky fixed this in r268138, and I've audited the kbd por= tions > > to make sure nothing would blow up due to the empty linker set and > > successfully compiled+ran a kernel with no keyboard support at all. > > > > Kill them off now since they're no longer required. > > > > MFC after: 1 week > > >=20 > It turns out that I missed one of these in > ^/sys/dev/terasic/mtl/terasic_mtl_syscons.c, which has the following > note that shows my analysis to be not inaccurate but incorrect: >=20 > /* > * XXXRW: For historical reasons, syscons can't register video consoles > * without a keyboard implementation. Provide a dummy. > */ >=20 > As far as I can tell, this isn't the case anymore as sckbdprobe's > return value is ignored and other references to the keyboard appear to > be properly gated on sc->keyboard being valid. >=20 > I only have a single machine that can run syscons, but I built a > kernel with the same modifications to remove all of the keyboard > drivers (-ukbd, kbdmux, hyperv) for that machine and encountered no > problems in practice. >=20 > I will proceed with removing the last dummy driver and MFC as scheduled. That's fine. I doubt anyone but us (CHERI) uses the Terasic MTL driver. -- Brooks --x+6KMIRAuhnl3hBn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJeDoxmAAoJEKzQXbSebgfApPoH/3WQNDoh8GXo0cH9HA2fnsdw i8AB+7iOiF+py2UootR3zTRJczhk1CrgOmbeo3I8NR1skdqi7m9Pw/FYNjTiUkeJ 50gdMQCSj0xUnt3/csqh5aAasQUiKiuvucG3xSfypbRIR4fVzFj/YbgkuWT+/1Q2 Nn81KCTOj1dKh1JZcFvvXTaCLg6poj8KhukoFreiqjohxYSieEwEm49/DJAr9am1 TUoE4JNd5LtorQp2vnTZQAkvwz4fNT//ycphUAlI4JdQEoffuzN0N+57JJTNt0cw XEzJYCuS2j2lqRxnhDvARcoHhINH+32c7UkEfuT63FO0Wh4Ig1KM7vumLKh8uxM= =zWS3 -----END PGP SIGNATURE----- --x+6KMIRAuhnl3hBn--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200103003551.GH91104>