Date: Mon, 22 May 2023 07:06:43 +0900 From: Tomoaki AOKI <junchoon@dec.sakura.ne.jp> To: Randall Stewart <rrs@FreeBSD.org> Cc: Antoine Brodin <antoine@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 73ee5756dee6 - main - Fixes in the tcp infrastructure with respect to stack changes as well as other infrastructure updates for incoming rack features. Message-ID: <20230522070643.99f8aa0c5509c0d3a5f2ae0b@dec.sakura.ne.jp>
next in thread | raw e-mail | index | archive | help
> On Tue, Apr 4, 2023 at 12:31 PM Randall Stewart <rrs@freebsd.org> wrote: >> >> The branch main has been updated by rrs: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f >> >> commit 73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f >> Author: Randall Stewart <rrs@FreeBSD.org> >> AuthorDate: 2023-04-01 05:46:38 +0000 >> Commit: Randall Stewart <rrs@FreeBSD.org> >> CommitDate: 2023-04-01 05:46:38 +0000 >> >> Fixes in the tcp infrastructure with respect to stack changes as well as other infrastructure updates for incoming rack features. >> >> So stack switching as always been a bit of a issue. We currently use a break before make setup which means that >> if something goes wrong you have to try to get back to a stack. This patch among a lot of other things changes that so >> that it is a make before break. We also expand some of the function blocks in prep for new features in rack that will allow >> more controlled pacing. We also add other abilities such as the pathway for a stack to query a previous stack to acquire from >> it critical state information so things in flight don't get dropped or mis-handled when switching stacks. We also add the >> concept of a timer granularity. This allows an alternate stack to change from the old ticks granularity to microseconds and >> of course this even gives us a pathway to go to nanosecond timekeeping if we need to (something for the data center to consider >> for sure). >> >> Once all this lands I will then update rack to begin using all these new features. >> >> Reviewed by: tuexen >> Sponsored by: Netflix Inc >> Differential Revision: https://reviews.freebsd.org/D39210 > > Hi, > > Could you hide some stuff in netinet/tcp.h? > struct http_req breaks curl 8.1.0. > > Antoine Please refer to Bug 271526 [1], especially Comment 4 [2] by Jonathan Reynolds. A patch is proposed there inline (not as an attachment). [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271526 [2] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271526#c4 -- Tomoaki AOKI <junchoon@dec.sakura.ne.jp>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20230522070643.99f8aa0c5509c0d3a5f2ae0b>