Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 2 Oct 2022 14:12:29 +0100
From:      "Alexander V. Chernikov" <melifaro@ipfw.ru>
To:        Larry Rosenman <ler@lerctr.org>
Cc:        Freebsd current <freebsd-current@freebsd.org>
Subject:   Re: Build Break?
Message-ID:  <7F2A1941-C042-47FF-969C-3D993D56D088@ipfw.ru>
In-Reply-To: <f649e982004a88f10aeccdcf3a82b199@lerctr.org>
References:  <f649e982004a88f10aeccdcf3a82b199@lerctr.org>

next in thread | previous in thread | raw e-mail | index | archive | help


> On 1 Oct 2022, at 22:57, Larry Rosenman <ler@lerctr.org> wrote:
>=20
> --- all_subdir_nfscommon ---
> Building =
/usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/n=
fscommon/nfs_commonkrpc.o
> --- all_subdir_netgraph ---
> --- all_subdir_netgraph/deflate ---
> Building =
/usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/n=
etgraph/deflate/offset.inc
> --- all_subdir_netgraph/device ---
> Building =
/usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/n=
etgraph/device/i386
> --- all_subdir_netgraph/echo ---
> =3D=3D=3D> netgraph/echo (all)
> --- all_subdir_netlink ---
> --- netlink_io.o ---
> /usr/src/sys/netlink/netlink_io.c:146:2: error: implicit declaration =
of function 'mtx_lock' is invalid in C99 =
[-Werror,-Wimplicit-function-declaration]
>        NLP_LOCK(nlp);
That=E2=80=99s interesting. netlink_io.c includes sys/mutex.h which =
defines mutex_lock() / mutex_unlock().
 Could you share the diff between GENERIC and LER-MINIMAL?

>        ^
> /usr/src/sys/netlink/netlink_var.h:79:25: note: expanded from macro =
'NLP_LOCK'
> #define NLP_LOCK(_nlp)          mtx_lock(&((_nlp)->nl_lock))
>                                ^
> /usr/src/sys/netlink/netlink_io.c:159:2: error: implicit declaration =
of function 'mtx_unlock' is invalid in C99 =
[-Werror,-Wimplicit-function-declaration]
>        NLP_UNLOCK(nlp);
>        ^
> /usr/src/sys/netlink/netlink_var.h:80:26: note: expanded from macro =
'NLP_UNLOCK'
> #define NLP_UNLOCK(_nlp)        mtx_unlock(&((_nlp)->nl_lock))
>                                ^
> /usr/src/sys/netlink/netlink_io.c:159:2: note: did you mean =
'mtx_lock'?
> /usr/src/sys/netlink/netlink_var.h:80:26: note: expanded from macro =
'NLP_UNLOCK'
> #define NLP_UNLOCK(_nlp)        mtx_unlock(&((_nlp)->nl_lock))
>                                ^
> /usr/src/sys/netlink/netlink_io.c:146:2: note: 'mtx_lock' declared =
here
>        NLP_LOCK(nlp);
>        ^
> /usr/src/sys/netlink/netlink_var.h:79:25: note: expanded from macro =
'NLP_LOCK'
> #define NLP_LOCK(_nlp)          mtx_lock(&((_nlp)->nl_lock))
>                                ^
> /usr/src/sys/netlink/netlink_io.c:177:2: error: implicit declaration =
of function 'mtx_lock' is invalid in C99 =
[-Werror,-Wimplicit-function-declaration]
>        SOCKBUF_LOCK(sb);
>        ^
> /usr/src/sys/sys/sockbuf.h:187:28: note: expanded from macro =
'SOCKBUF_LOCK'
> #define SOCKBUF_LOCK(_sb)               mtx_lock(SOCKBUF_MTX(_sb))
>                                        ^
> /usr/src/sys/netlink/netlink_io.c:189:2: error: implicit declaration =
of function 'mtx_unlock' is invalid in C99 =
[-Werror,-Wimplicit-function-declaration]
>        SOCKBUF_UNLOCK(sb);
>        ^
> /usr/src/sys/sys/sockbuf.h:189:30: note: expanded from macro =
'SOCKBUF_UNLOCK'
> #define SOCKBUF_UNLOCK(_sb)             mtx_unlock(SOCKBUF_MTX(_sb))
>                                        ^
> /usr/src/sys/netlink/netlink_io.c:202:2: error: implicit declaration =
of function 'mtx_lock' is invalid in C99 =
[-Werror,-Wimplicit-function-declaration]
>        NLP_LOCK(nlp);
>        ^
> /usr/src/sys/netlink/netlink_var.h:79:25: note: expanded from macro =
'NLP_LOCK'
> #define NLP_LOCK(_nlp)          mtx_lock(&((_nlp)->nl_lock))
>                                ^
> /usr/src/sys/netlink/netlink_io.c:207:3: error: implicit declaration =
of function 'mtx_unlock' is invalid in C99 =
[-Werror,-Wimplicit-function-declaration]
>                NLP_UNLOCK(nlp);
>                ^
> /usr/src/sys/netlink/netlink_var.h:80:26: note: expanded from macro =
'NLP_UNLOCK'
> #define NLP_UNLOCK(_nlp)        mtx_unlock(&((_nlp)->nl_lock))
>                                ^
> /usr/src/sys/netlink/netlink_io.c:225:3: error: implicit declaration =
of function 'mtx_unlock' is invalid in C99 =
[-Werror,-Wimplicit-function-declaration]
>                SOCKBUF_UNLOCK(sb);
>                ^
> /usr/src/sys/sys/sockbuf.h:189:30: note: expanded from macro =
'SOCKBUF_UNLOCK'
> #define SOCKBUF_UNLOCK(_sb)             mtx_unlock(SOCKBUF_MTX(_sb))
>                                        ^
> /usr/src/sys/netlink/netlink_io.c:232:2: error: implicit declaration =
of function 'mtx_unlock' is invalid in C99 =
[-Werror,-Wimplicit-function-declaration]
>        NLP_UNLOCK(nlp);
>        ^
> /usr/src/sys/netlink/netlink_var.h:80:26: note: expanded from macro =
'NLP_UNLOCK'
> #define NLP_UNLOCK(_nlp)        mtx_unlock(&((_nlp)->nl_lock))
>                                ^
> /usr/src/sys/netlink/netlink_io.c:281:2: error: implicit declaration =
of function 'mtx_lock' is invalid in C99 =
[-Werror,-Wimplicit-function-declaration]
>        NLP_LOCK(nlp);
>        ^
> /usr/src/sys/netlink/netlink_var.h:79:25: note: expanded from macro =
'NLP_LOCK'
> #define NLP_LOCK(_nlp)          mtx_lock(&((_nlp)->nl_lock))
>                                ^
> /usr/src/sys/netlink/netlink_io.c:299:2: error: implicit declaration =
of function 'mtx_unlock' is invalid in C99 =
[-Werror,-Wimplicit-function-declaration]
>        NLP_UNLOCK(nlp);
>        ^
> /usr/src/sys/netlink/netlink_var.h:80:26: note: expanded from macro =
'NLP_UNLOCK'
> #define NLP_UNLOCK(_nlp)        mtx_unlock(&((_nlp)->nl_lock))
>                                ^
> /usr/src/sys/netlink/netlink_io.c:354:2: error: implicit declaration =
of function 'mtx_lock' is invalid in C99 =
[-Werror,-Wimplicit-function-declaration]
>        NLP_LOCK(nlp);
>        ^
> /usr/src/sys/netlink/netlink_var.h:79:25: note: expanded from macro =
'NLP_LOCK'
> #define NLP_LOCK(_nlp)          mtx_lock(&((_nlp)->nl_lock))
>                                ^
> /usr/src/sys/netlink/netlink_io.c:357:3: error: implicit declaration =
of function 'mtx_unlock' is invalid in C99 =
[-Werror,-Wimplicit-function-declaration]
>                NLP_UNLOCK(nlp);
>                ^
> /usr/src/sys/netlink/netlink_var.h:80:26: note: expanded from macro =
'NLP_UNLOCK'
> #define NLP_UNLOCK(_nlp)        mtx_unlock(&((_nlp)->nl_lock))
>                                ^
> /usr/src/sys/netlink/netlink_io.c:369:3: error: implicit declaration =
of function 'mtx_unlock' is invalid in C99 =
[-Werror,-Wimplicit-function-declaration]
>                NLP_UNLOCK(nlp);
>                ^
> /usr/src/sys/netlink/netlink_var.h:80:26: note: expanded from macro =
'NLP_UNLOCK'
> #define NLP_UNLOCK(_nlp)        mtx_unlock(&((_nlp)->nl_lock))
>                                ^
> /usr/src/sys/netlink/netlink_io.c:395:2: error: implicit declaration =
of function 'mtx_unlock' is invalid in C99 =
[-Werror,-Wimplicit-function-declaration]
>        NLP_UNLOCK(nlp);
>        ^
> /usr/src/sys/netlink/netlink_var.h:80:26: note: expanded from macro =
'NLP_UNLOCK'
> #define NLP_UNLOCK(_nlp)        mtx_unlock(&((_nlp)->nl_lock))
>                                ^
> /usr/src/sys/netlink/netlink_io.c:519:3: error: implicit declaration =
of function 'mtx_lock' is invalid in C99 =
[-Werror,-Wimplicit-function-declaration]
>                NLP_LOCK(nlp);
>                ^
> /usr/src/sys/netlink/netlink_var.h:79:25: note: expanded from macro =
'NLP_LOCK'
> #define NLP_LOCK(_nlp)          mtx_lock(&((_nlp)->nl_lock))
>                                ^
> /usr/src/sys/netlink/netlink_io.c:521:3: error: implicit declaration =
of function 'mtx_unlock' is invalid in C99 =
[-Werror,-Wimplicit-function-declaration]
>                NLP_UNLOCK(nlp);
>                ^
> /usr/src/sys/netlink/netlink_var.h:80:26: note: expanded from macro =
'NLP_UNLOCK'
> #define NLP_UNLOCK(_nlp)        mtx_unlock(&((_nlp)->nl_lock))
>                                ^
> 16 errors generated.
> --- all_subdir_netgraph ---
> --- all_subdir_netgraph/device ---
> --- i386 ---
> i386 -> /usr/src/sys/i386/include
> Building =
/usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/n=
etgraph/device/vnode_if_newproto.h
> --- all_subdir_netlink ---
> *** [netlink_io.o] Error code 1
>=20
> make[4]: stopped in /usr/src/sys/modules/netlink
> .ERROR_TARGET=3D'netlink_io.o'
> =
.ERROR_META_FILE=3D'/usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/u=
sr/src/sys/modules/netlink/netlink_io.o.meta'
> .MAKE.LEVEL=3D'4'
> MAKEFILE=3D''
> .MAKE.MODE=3D'meta missing-filemon=3Dyes missing-meta=3Dyes silent=3Dyes=
 verbose'
>        5.79 real        30.04 user         9.35 sys
>=20
> make[1]: stopped in /usr/src
>=20
> make: stopped in /usr/src
>=20
> ler in =F0=9F=8C=90 borg in src=F0=9F=94=92 on =EE=82=A0 =
ler/freebsd-main-changes:main [=E2=87=A1] on =E2=98=81=EF=B8=8F  =
(us-east-1) took 1m56s
> =E2=9D=AF
>=20
> ler in =F0=9F=8C=90 borg in src=F0=9F=94=92 on =EE=82=A0 =
ler/freebsd-main-changes:main [=E2=87=A1] on =E2=98=81=EF=B8=8F  =
(us-east-1)
> =E2=9D=AF
>=20
>=20
>=20
> --=20
> Larry Rosenman                     http://www.lerctr.org/~ler
> Phone: +1 214-642-9640                 E-Mail: ler@lerctr.org
> US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106
>=20




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7F2A1941-C042-47FF-969C-3D993D56D088>