Date: Tue, 16 Jun 2020 20:33:10 -0600 From: Ian Lepore <ian@freebsd.org> To: Kristof Provost <kp@FreeBSD.org>, Ed Maste <emaste@freebsd.org> Cc: Toomas Soome <tsoome@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r362217 - head/stand/common Message-ID: <8948411d5bb0ab7ffae4c9cba06bda7b8943e0cd.camel@freebsd.org> In-Reply-To: <E023EB92-0AC3-4AD8-A309-81AA6E07F80F@FreeBSD.org> References: <202006160705.05G753T4057972@repo.freebsd.org> <55903c38d363aef2a6f6d0075dd4526b86d51258.camel@freebsd.org> <CAPyFy2D1mhkxR00BGB1Ufn3PLRe%2Bb-t%2Bz_bgss=7am%2Bn3inWjw@mail.gmail.com> <E023EB92-0AC3-4AD8-A309-81AA6E07F80F@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2020-06-16 at 19:34 +0200, Kristof Provost wrote: > On 16 Jun 2020, at 19:11, Ed Maste wrote: > > On Tue, 16 Jun 2020 at 13:01, Ian Lepore <ian@freebsd.org> wrote: > > > > > > As much as I prefer doing it this way, style(9) doesn't allow for > > > variable declarations inside a for() statement (or even inside a > > > local > > > block, which is just too 1980s for me, but it is still our standard). > > > > Perhaps it's time to update style(9) to at least permit these uses, as > > we've done with the blank line at the beginning of functions with no > > local variables, and with braces around single-line bodies. > > We have 431 instances of `for (int i` in sys alone. It¢s not so much a > question of allowing it as acknowledging reality at this point. > > Best regards, > Kristof Hmm, so we do. If you weed out sys/contrib, and device drivers contributed by vendors, the number is a lot smaller, but still big enough that we should just change the rules I think. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8948411d5bb0ab7ffae4c9cba06bda7b8943e0cd.camel>