Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 30 Nov 2021 03:24:32 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 260128] "make tags" fails with "gtags not found", src/Makefile undesirably rewrites PATH
Message-ID:  <bug-260128-227-O2AzJJretz@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-260128-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-260128-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260128

--- Comment #1 from Jory Folker <jfolker11@gmail.com> ---
As it turns out, I was too groggy from coughing my lungs out (and NyQuil) to
notice the cause sitting right there in plain sight, line 215 of Makefile:

PATH=3D /sbin:/bin:/usr/sbin:/usr/bin

This is flat-out wrong. Note that the first n directories in the default PA=
TH
for root are identical, in line 22 of /root/.cshrc:

set path =3D (/sbin /bin /usr/sbin /usr/bin /usr/local/sbin /usr/local/bin
$HOME/bin)

If the user prepends directories onto PATH in /root/.cshrc and breaks their=
 own
build by calling a version of an executable (e.g. gtags) not explicitly
maintained for build purposes, I don't think it's unreasonable to call it p=
ilot
error.

We should also consider the undue hassle to some LLVM maintainer testing th=
eir
experimental clang build.

My proposed fix to remove this line from src/Makefile is included at the bo=
ttom
of this message.


215d214
< PATH=3D /sbin:/bin:/usr/sbin:/usr/bin

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-260128-227-O2AzJJretz>