Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 1 Apr 2026 13:26:23 +0000 (UTC)
From:      "Bjoern A. Zeeb" <bz@FreeBSD.org>
To:        Gleb Smirnoff <glebius@FreeBSD.org>
Cc:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org,  dev-commits-src-main@FreeBSD.org
Subject:   Re: git: 407b1e498018 - main - rss: make toeplitz.c standard part of the kernel
Message-ID:  <s36143q-3o9p-5q50-5qps-28p9n157o7n4@mnoonqbm.arg>
In-Reply-To: <69cbfb76.403b1.24e43318@gitrepo.freebsd.org>

index | next in thread | previous in thread | raw e-mail

On Tue, 31 Mar 2026, Gleb Smirnoff wrote:

> The branch main has been updated by glebius:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=407b1e4980189252fade78438aa08191a9883cdc
>
> commit 407b1e4980189252fade78438aa08191a9883cdc
> Author:     Gleb Smirnoff <glebius@FreeBSD.org>
> AuthorDate: 2026-03-31 16:34:51 +0000
> Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
> CommitDate: 2026-03-31 16:34:51 +0000
>
>    rss: make toeplitz.c standard part of the kernel
>
>    This will fix LINT-NOIP build.  This actually adds very little to the
>    kernel text, e.g. 500 bytes on amd64.  A perfect solution would be to
>    instead declare rss_config.c as 'optional inet | inet6', but that would
>    fail to build LINT-NOIP in several NIC drivers, that use RSS and
>    absolutely ignore that both INET and INET6 are optional.  It is very
>    unlikely that vendors who maintain these drivers will will ever chase the
>    holy grail of a build that doesn't support IPv4 and IPv6.

Well, we had this sorted for LRO and other bits and had made them
conditional depending on INET6 or INET in drivers, which in the
end brought no-IP compiling for free.

Given we these days do not support any non-IP protocol in-tree anymore
it seems, it is very unlikely we want any of these drivers with NO-IP
either.


>    Fixes:  d9c55b2e8cd6b79f6926278e10a79f1bcca27a4b
> ---
> sys/conf/files | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sys/conf/files b/sys/conf/files
> index de13b76e71a4..347dadb1545f 100644
> --- a/sys/conf/files
> +++ b/sys/conf/files
> @@ -4263,7 +4263,7 @@ net/route/route_temporal.c	standard
> net/rss_config.c		standard
> net/rtsock.c			standard
> net/slcompress.c		optional netgraph_vjc
> -net/toeplitz.c			optional inet | inet6
> +net/toeplitz.c			standard
> net/vnet.c			optional vimage
> net80211/ieee80211.c		optional wlan
> net80211/ieee80211_acl.c	optional wlan wlan_acl
>
>

-- 
Bjoern A. Zeeb                                                     r15:7


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?s36143q-3o9p-5q50-5qps-28p9n157o7n4>