Date: Tue, 21 Jan 2003 22:22:51 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: nate@root.org Cc: bde@zeta.org.au, alfred@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha busdma_machdep.c src/sys/alpha/osf1 imgact_osf1.c osf1_misc.c src/sys/cam cam_periph.c cam_sim.c cam_xpt.c src/sys/cam/scsi scsi_cd.c scsi_ch.c scsi Message-ID: <20030121.222251.71550060.imp@bsdimp.com> In-Reply-To: <Pine.BSF.4.21.0301211726290.66961-100000@root.org> References: <20030122100003.K30758-100000@gamplex.bde.org> <Pine.BSF.4.21.0301211726290.66961-100000@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <Pine.BSF.4.21.0301211726290.66961-100000@root.org>
Nate Lawson <nate@root.org> writes:
: On Wed, 22 Jan 2003, Bruce Evans wrote:
: > > On Tue, 21 Jan 2003, Alfred Perlstein wrote:
: > > > Log:
: > > > Remove M_TRYWAIT/M_WAITOK/M_WAIT. Callers should use 0.
: > > > Merge M_NOWAIT/M_DONTWAIT into a single flag M_NOWAIT.
: >
: > Robert Watson wrote:
: > > Hmm. I guess I missed the discussion; I'm a bit behind on mailing lists.
: > > To improve code portability and careful thinking by developers, what I'd
: > > like to see is something more like the following: M_WAITOK, which
: > > explicitly requests sleeping indefinitely, M_NOWAIT, which explicitly
: > > requests no sleeping. Rather than a "default" value, a
: >
: > That's exactly what M_WAITOK was supposed to do. Developers just had to
: > think about it since it wasn't really a flag so it was not easy to check
: > automatically.
:
: I like Robert's approach -- keep the flags as they were before but give
: M_WAITOK a value other than 0 and deprecate passing in 0 as an arg. This
: change only would affect binary kld compat and if 0 only generated a
: printf warning (one-shot) but still meant M_WAITOK for a little while,
: that would ease the migration.
Doing it as a one-shot is useless. "Something is broken" isn't a
useful diagnostic.
Warner
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030121.222251.71550060.imp>