Date: Sat, 20 Dec 2008 13:55:05 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Maxim Sobolev <sobomax@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, "David E. O'Brien" <obrien@freebsd.org> Subject: Re: svn: head/usr.sbin/burncd Message-ID: <20081220115505.GZ2038@deviant.kiev.zoral.com.ua> In-Reply-To: <494C097C.1020604@FreeBSD.org> References: <200812192020.mBJKKEIo081792@svn.freebsd.org> <494C097C.1020604@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--OM3frZe47dgZ1O53 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 19, 2008 at 12:52:12PM -0800, Maxim Sobolev wrote: > Should not it be better to implement this on the kernel side when the=20 > device is closed abruptly? The state that is kept is not accumulated on any particular filedescriptor, it is associated with the physical state of the device. Therefore, I think that kernel shall not be charged with cleanup, and userspace calls should deal with resetting device back to the pristine state. >=20 > David E. O'Brien wrote: > >Author: obrien > >Date: Fri Dec 19 20:20:14 2008 > >New Revision: 186337 > >URL: http://svn.freebsd.org/changeset/base/186337 > > > >Log: > > burncd(8) doesn't handle signals and interrupting burncd during=20 > > operation. > > For example, ^C (SIGINT) may leave the drive spinning and locked. > > This may also happen if you try to write a too-large image to a disc > > and burncd(8) exits with an I/O error. > > =20 > > Add signal handling by doing a CDRIOCFLUSH ioctl to attempt to leave > > burner in a sane state when burning is interrupted with SIGHUP, SIGINT, > > SIGTERM, or in case an I/O error occurs during write. > > Note, that blanking will still continue after interrupt but it seems to > > finish correctly even after burncd(8) has quit. >=20 > -Maxim --OM3frZe47dgZ1O53 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAklM3RkACgkQC3+MBN1Mb4gP9QCdEf4Cx27uFgNZr1+2D4YFj3H0 FSMAn1dbiKVrEcCuBUAkmjmFJhygizAa =hwah -----END PGP SIGNATURE----- --OM3frZe47dgZ1O53--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081220115505.GZ2038>