Date: Fri, 10 Apr 2020 10:26:37 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: rgrimes@freebsd.org, Maxim Sobolev <sobomax@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r359685 - in head: . etc lib/libc/gen share/mk share/termcap usr.bin/login usr.bin/vgrind usr.sbin/services_mkdb Message-ID: <3e0a6d83-e99b-1e09-89e5-c202dbef9433@FreeBSD.org> In-Reply-To: <202004071037.037Abd5T091937@gndrsh.dnsmgr.net> References: <202004071037.037Abd5T091937@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UbftOwhhbNfgQ3S4B2To81yrQN1ylYFgm Content-Type: multipart/mixed; boundary="nQFmy8lbwr16kiTrqvEArL9KfYRtiu07u"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: rgrimes@freebsd.org, Maxim Sobolev <sobomax@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <3e0a6d83-e99b-1e09-89e5-c202dbef9433@FreeBSD.org> Subject: Re: svn commit: r359685 - in head: . etc lib/libc/gen share/mk share/termcap usr.bin/login usr.bin/vgrind usr.sbin/services_mkdb References: <202004071037.037Abd5T091937@gndrsh.dnsmgr.net> In-Reply-To: <202004071037.037Abd5T091937@gndrsh.dnsmgr.net> --nQFmy8lbwr16kiTrqvEArL9KfYRtiu07u Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 4/7/2020 3:37 AM, Rodney W. Grimes wrote: >> Author: sobomax >> Date: Tue Apr 7 02:46:22 2020 >> New Revision: 359685 >> URL: https://svnweb.freebsd.org/changeset/base/359685 >> >> Log: >> Normalize deployment tools usage and definitions by putting into one= place >> instead of sprinkling them out over many disjoint files. This is a f= ollow-up >> to achieve the same goal in an incomplete rev.348521. > I have concerns that this factoring out of 5 values that have not chang= ed > in 25 years is a pessimization, it is one more file that make has to > open on each invocation. >=20 >=20 The truth is that this additional file read is on top of hundreds of new reads per directory in the past few years. It can suck on NFS but otherwise this 1 change is very minor compared to other additions. One big example is foo.o.depend for each foo.o. Or bmake doing realpath(getcwd()) on every invocation. Improving those, or the bmake job queue, or bmake's overuse of /bin/sh, would go a lot further than the hit from this commit. --=20 Regards, Bryan Drewery --nQFmy8lbwr16kiTrqvEArL9KfYRtiu07u-- --UbftOwhhbNfgQ3S4B2To81yrQN1ylYFgm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEE+Rc8ssOq6npcih8JNddxu25Gl88FAl6QrE1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY5 MTczQ0IyQzNBQUVBN0E1QzhBMUYwOTM1RDc3MUJCNkU0Njk3Q0YACgkQNddxu25G l8/Upgf/WDWFT8iahP+M+48rdNLykOIyeSIxDSx9pfzVfw4V2pEmOVqsoxALfj/G igHbbLSI2GMn+w7A4enNh6I3aG9mPz2I4Sx/KK381V+WWkTwarhIKRtv6Dq1lwXk cRp+CSJCZnMPiZI3xin/LkHA8NJgVwKsajtlGiCyZFfCVaQVFuFgigPl1va5hJG0 21GrDBToYwEAeaj80uH36oXfHxjV81Dh+e0lZw7kMrVD6M9UCk/ov2H+MfPMB9qu QIIQsUXXKD5LxUu0QVbdUEeC0ZH37jEVd/PdmdDZesV2H/aqQuGwqdvqn03NUN1P jK1xMqk5xj2RasLuz1nmmAOZBI81cw== =BcP1 -----END PGP SIGNATURE----- --UbftOwhhbNfgQ3S4B2To81yrQN1ylYFgm--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3e0a6d83-e99b-1e09-89e5-c202dbef9433>