Date: Fri, 15 May 2020 13:17:24 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: Ryan Moeller <freqlabs@freebsd.org> Cc: rgrimes@freebsd.org, Mateusz Piotrowski <0mp@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r361066 - head/usr.sbin/jail Message-ID: <202005152017.04FKHOcg088160@gndrsh.dnsmgr.net> In-Reply-To: <ceab2e95-b4b6-c969-838a-8014f279220a@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 5/15/20 3:24 PM, Rodney W. Grimes wrote: > > >> On 5/15/20 6:18 AM, Mateusz Piotrowski wrote: > >> > >>> On 5/15/20 1:38 AM, Ryan Moeller wrote: > >>>> Author: freqlabs > >>>> Date: Thu May 14 23:38:11 2020 > >>>> New Revision: 361066 > >>>> URL: https://svnweb.freebsd.org/changeset/base/361066 > >>>> > >>>> Log: > >>>> jail: Add exec.prepare and exec.release command hooks > >>>> > >>>> This change introduces new jail command hooks that run before and after any > >>>> other actions. > >>> Should it go into RELNOTES? > >> I'm not sure what all the criteria are for relnotes. > >> The committer's guide makes it seem like relnotes is for breaking > >> changes, which this is not. > > Please could you point at which specific language in the commiters > > guide makes you believe that the RELNOTES are for breaking changes? > > Every mention of "release notes" in the document is in the context of > deprecating, removing, > or breaking things, with one exception: Fair, there should be a section on "new features and enhnacements" which is laking. However if one reads a release notes from a shipping version it becomes clear that the actual majority of the text in it is "new stuff." > > Relnotes:??? If the change is a candidate for inclusion in the > release notes for the next release from the branch, set to yes. > > > > RELNOTES should be for all changes that have user visible impact > > of any type. > > > >> -Ryan > -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202005152017.04FKHOcg088160>