Date: Thu, 24 Mar 2005 15:55:59 -0500 From: John Baldwin <jhb@FreeBSD.org> To: Brooks Davis <brooks@one-eyed-alien.net> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/linux linux_ioctl.c Message-ID: <200503241555.59177.jhb@FreeBSD.org> In-Reply-To: <20050324201936.GA30850@odin.ac.hmc.edu> References: <200503241751.j2OHpFQg063306@repoman.freebsd.org> <20050324200942.GK46915@wombat.fafoe.narf.at> <20050324201936.GA30850@odin.ac.hmc.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 24 March 2005 03:19 pm, Brooks Davis wrote: > On Thu, Mar 24, 2005 at 09:09:43PM +0100, Stefan Farfeleder wrote: > > On Thu, Mar 24, 2005 at 12:02:10PM -0800, Brooks Davis wrote: > > > Prior to C99, I think #error wasn't specified. C99 does specify it. > > > > C89/90 had #error too. > > I stand corrected. Now that I think about it, all but the perverse > preprocessors would implement #error just by blowing up on an unknown > directive so even that isn't an issue. In any case, I've made the > change and the new code is at least shorter. It's really only there for > people mucking with kernel internals who should be able to figure out > what it means. We could always just change CTASSERT() to use #error if that is better. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200503241555.59177.jhb>