Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Nov 2019 23:50:44 +0100
From:      Olivier Houchard <cognet@ci0.org>
To:        Ian Lepore <ian@freebsd.org>
Cc:        Justin Hibbits <jhibbits@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r354714 - in head/sys: arm64/arm64 arm64/conf arm64/include conf
Message-ID:  <20191114225044.GA84576@ci0.org>
In-Reply-To: <9e8c5e79c48f3f751723e96e5b3fb1b03a51c9c3.camel@freebsd.org>
References:  <201911142158.xAELwemi048354@repo.freebsd.org> <9e8c5e79c48f3f751723e96e5b3fb1b03a51c9c3.camel@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 14, 2019 at 03:24:30PM -0700, Ian Lepore wrote:
> On Thu, 2019-11-14 at 21:58 +0000, Justin Hibbits wrote:
> > Author: jhibbits
> > Date: Thu Nov 14 21:58:40 2019
> > New Revision: 354714
> > URL: https://svnweb.freebsd.org/changeset/base/354714
> > 
> > Log:
> >   Boot arm64 kernel using booti command from U-boot.
> >   
> > [...]
> > 
> > Added: head/sys/arm64/arm64/machdep_boot.c
> > =====================================================================
> > =========
> > --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> > +++ head/sys/arm64/arm64/machdep_boot.c	Thu Nov 14 21:58:40
> > 2019	(r354714)
> > @@ -0,0 +1,330 @@
> > +/*-
> > + * Copyright (c) 2019 Juniper Networks, Inc
> > + * Copyright (c) 2004 Olivier Houchard
> > + * Copyright (c) 1994-1998 Mark Brinicombe.
> > + * Copyright (c) 1994 Brini.
> > + * All rights reserved.
> > + *
> > 
> 
> I think this copyright list should be pared down to just Olivier
> (maybe?) and Juniper.  The Brini lines are from when this code was part
> of machdep.c that was imported from netbsd in the 2004 timeframe.  That
> import did not include any of the code that got copied into this new
> arm64 file.  The code to handle embedded dtb and parsing bootargs in
> various ABI formats was all added much more recently, 2012-2014 time
> frame.
> 
> Warner should probably add himself to the copyrights though, I'm pretty
> sure he's the one who wrote the various flavors of bootargs parsers.
> 

There's actually still code of mine in this, well some descendant of it,
all the fake metadata business, but I'm amazed it's still used today,
especially on arm64, it was there to provide minimal infos back when we
had no real bootloader on arm.
Warner's copyright definitively belongs here.

Regards,

Olivier



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191114225044.GA84576>