Date: Fri, 24 Jan 2025 14:36:07 GMT From: Mark Johnston <markj@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 16369f33c5d9 - main - inpcb: Remove an incorrect assertion in in_pcblbgroup_find() Message-ID: <202501241436.50OEa7DC006646@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=16369f33c5d920c614d0778642364ee1213e6069 commit 16369f33c5d920c614d0778642364ee1213e6069 Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2025-01-24 14:22:54 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2025-01-24 14:22:54 +0000 inpcb: Remove an incorrect assertion in in_pcblbgroup_find() The inpcb might indeed not belong to a load-balancing group when passed from in_pcblbgroup_numa(). Reported by: syzbot+58bb60fe7a452df78835@syzkaller.appspotmail.com Fixes: 7cbb6b6e28db ("inpcb: Close some SO_REUSEPORT_LB races, part 2") --- sys/netinet/in_pcb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/netinet/in_pcb.c b/sys/netinet/in_pcb.c index c50e39f20c16..f9eac96acd5b 100644 --- a/sys/netinet/in_pcb.c +++ b/sys/netinet/in_pcb.c @@ -304,8 +304,6 @@ in_pcblbgroup_find(struct inpcb *inp) pcbinfo = inp->inp_pcbinfo; INP_HASH_LOCK_ASSERT(pcbinfo); - KASSERT((inp->inp_flags & INP_INLBGROUP) != 0, - ("inpcb %p is not in a load balance group", inp)); hdr = &pcbinfo->ipi_lbgrouphashbase[ INP_PCBPORTHASH(inp->inp_lport, pcbinfo->ipi_lbgrouphashmask)];
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202501241436.50OEa7DC006646>