Date: Sat, 26 Mar 2005 15:08:22 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
To: Brooks Davis <brooks@one-eyed-alien.net>
Cc: arch@freebsd.org
Subject: Re: -I${CURDIR}/../../sys in src/*bin/Makefiles
Message-ID: <20050326143417.J3715@delplex.bde.org>
In-Reply-To: <20050325223925.GB1944@odin.ac.hmc.edu>
References: <20050325223925.GB1944@odin.ac.hmc.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 25 Mar 2005, Brooks Davis wrote:
> In PR bin/79229 the submitter suggests that we add -I${CURDIR}/../../sys
> to CFLAGS in sbin/ifconfig/Makefile. I initially responded that we
> don't normally do that because buildworld handles picking up the latest
> headers, but after greping other Makefiles in sbin, I found that we
> do actually do that in a number of cases. It seems to me that we
> should really make up our mind which one we should do. I'm somewhat
> disinclined to add -I's to every utility, but that's not a strong
> opinion. What do others thing?
This is a bug in the other Makefiles. It is not needed for full builds,
and breaks some cases for building just one utility (ones where libraries
are consistent with <sys> but not with ${CURDIR}/../../sys, and the
utility sources are either old so that they match <sys> or haven't
changed so much that they need new system headers). It is just a hack
that "fixes" a different set of cases (ones where the utility sources
match ${CURDIR}/../../sys, and the installed libraries are either new
so that they match ${CURDIR}/../../sys but not <sys> (unlikely) or
haven't change so much that they don't work with utilities compiled
with new system headers).
I thought that ru fixed it. Well, that was a long time ago and the
bug seems to be mainly in newer Makefiles. ps/Makefile was fixed in
rev.1.14 (2001/05/18).
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050326143417.J3715>