Date: Fri, 15 Mar 2019 11:18:12 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: rgrimes@freebsd.org, araujo@freebsd.org Cc: Ian Lepore <ian@freebsd.org>, Chuck Tuffli <chuck@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r345171 - head/usr.sbin/bhyve Message-ID: <6f9466bd-a282-e329-dd7c-13aef8deadaf@FreeBSD.org> In-Reply-To: <201903151603.x2FG3pIp030819@gndrsh.dnsmgr.net> References: <201903151603.x2FG3pIp030819@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15/03/2019 11:03, Rodney W. Grimes wrote: >> Em sex, 15 de mar de 2019 ?s 22:12, Ian Lepore <ian@freebsd.org> escreveu: >> >>> On Thu, 2019-03-14 at 19:31 -0700, Rodney W. Grimes wrote: >>>>> Author: chuck >>>>> Date: Fri Mar 15 02:11:28 2019 >>>>> New Revision: 345171 >>>>> URL: https://svnweb.freebsd.org/changeset/base/345171 >>>>> >>>>> Log: >>>>> Fix bhyve PCIe capability emulation >>>>> >>>>> PCIe devices starting with version 1.1 must set the Role-Based >>>>> Error >>>>> Reporting bit. >>>>> >>>>> And while we're in the neighborhood, generalize the code >>>>> assigning the >>>>> device type. >>>>> >>>>> Reviewed by: imp, araujo, rgrimes >>>>> Approved by: imp (mentor) >>>>> MFC after: 1 week >>>>> Differential Revision: https://reviews.freebsd.org/D19580 >>>> This code requires maintainer approval before a commit, >>>> though this was well reviewed that doesnt exclude it >>>> from the MAINTAINERS entry. >>>> >>> Where exactly does it say that in MAINTAINERS? As another victim of >>> this sort of drive-by lynching after making a trivial bhyve change I >>> pretty seriously object to a vague and meaningless entry in MAINTAINERS >>> being used to pounce on anyone who dares to touch the precious bhyve >>> code. >>> >> There is a new entry on MAINTAINERS: >> https://svnweb.freebsd.org/base?view=revision&revision=344631 >> >> >>> There is no mention of bhyve in MAINTAINERS, for usr.sbin or elsewhere. >>> There is an entry for vmm(4), which to me does not say anything about >>> bhyve, yet somehow everybody is supposed to know what it means and >>> what-all territory it covers? >>> >>> IMO, this sort of hyper-proprietary pouncing on everyone who dares >>> change a single line of code is not productive. It is HIGHLY de- >>> motivating. Large sweeping design changes are one thing, but pouncing >>> on every tiny minor commit is just not helpful. >>> >> +1 >> >> I got so frustrated with it recently that I have decided to don't >> contribute with bhyve anymore, perhaps even with FreeBSD. >> I still have some people under mentorship that I intend to finish and then >> probably I will phase out. > Your failure to get reviews, and infact even abandon one that had > negative advice as to the validity of your suggested change and > committing it anyway is more likely the cause here. I will have to add to the choir here: getting reviews is not mandatory and I hope they will never be. Reviewed code is likely to have less errors but sometimes we just need to get things done. Look, for example, the case of the automounting daemon amd(8), which we have been planning to remove for some years: your unfortunate intervention stopped it from getting removed from the system for how many months(?) stopping progress there altogether. Pedro. > You also committed code with no review at all that had to be reverted > after the bugs it caused were found by an external down stream consumers > of the bhyve code. > > You had code reverted by core due to a external attribution request, > which had you been attending the bi monthly bhyve calls you would of > known was an issue. > > I would suggest these are the reasons your feeling angry, and that > I infact tried to reach out to jhb to discuss some of these earlier > but that reach out was never returned. I under stand your frustration, > you are just wanting to do with best thing you can for the project > and bhyve, can we try to find a better resolution to this situation > than your exit? > >>> -- Ian >>> >>>> Leave it for now, I am sure jhb or thyco are fine with it, >>>> this is just a heads up FYI for future commits. >>>> >>>> Bhyve code has been and still is under a fairly tight >>>> MAINTAINER status. >>>> >>>>> Modified: >>>>> head/usr.sbin/bhyve/pci_emul.c >>>>> >>>>> Modified: head/usr.sbin/bhyve/pci_emul.c >>>>> =================================================================== >>>>> =========== >>>>> --- head/usr.sbin/bhyve/pci_emul.c Fri Mar 15 02:11:27 2019 (r3 >>>>> 45170) >>>>> +++ head/usr.sbin/bhyve/pci_emul.c Fri Mar 15 02:11:28 2019 (r3 >>>>> 45171) >>>>> @@ -953,7 +953,10 @@ pci_emul_add_pciecap(struct pci_devinst *pi, >>>>> int type) >>>>> bzero(&pciecap, sizeof(pciecap)); >>>>> >>>>> pciecap.capid = PCIY_EXPRESS; >>>>> - pciecap.pcie_capabilities = PCIECAP_VERSION | >>>>> PCIEM_TYPE_ROOT_PORT; >>>>> + pciecap.pcie_capabilities = PCIECAP_VERSION | type; >>>>> + /* Devices starting with version 1.1 must set the RBER bit */ >>>>> + if (PCIECAP_VERSION >= 1) >>>>> + pciecap.dev_capabilities = PCIEM_CAP_ROLE_ERR_RPT; >>>>> pciecap.link_capabilities = 0x411; /* gen1, x1 */ >>>>> pciecap.link_status = 0x11; /* gen1, x1 */ >>>>> >>>>> >>>>> >>>> >>> >>> >> -- >> >> -- >> Marcelo Araujo (__)araujo@FreeBSD.org >> \\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>; \/ \ ^ >> Power To Server. .\. /_)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6f9466bd-a282-e329-dd7c-13aef8deadaf>