Date: Wed, 5 Feb 2014 08:54:15 -0500 From: Shawn Webb <lattera@gmail.com> To: =?ISO-8859-1?Q?Olivier_Cochard=2DLabb=E9?= <olivier@cochard.me> Cc: freebsd-bugs@freebsd.org Subject: Re: kern/181497: [kernel] [patch] Add ASLR feature to kernel Message-ID: <CADt0fhxWeqkkjVrOG5B2gEN_3kfharkJXudEovVbj54%2BeBOckA@mail.gmail.com> In-Reply-To: <CA%2Bq%2BTcpvW3c9c%2B4XJA1MLaMyi5xOSLtjqA5nkPJncGJ%2BJhY2KA@mail.gmail.com> References: <201402042000.s14K01eo021855@freefall.freebsd.org> <CA%2Bq%2BTcpvW3c9c%2B4XJA1MLaMyi5xOSLtjqA5nkPJncGJ%2BJhY2KA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Looks like that variable is missing in that struct. The exec delta variable changes how the binary itself and the RTLD is loaded. I'll fix the warnings and errors you reported today. Thanks for helping! On Wed, Feb 5, 2014 at 3:56 AM, Olivier Cochard-Labb=E9 <olivier@cochard.me= >wrote: > On Tue, Feb 4, 2014 at 9:00 PM, Shawn Webb <lattera@gmail.com> wrote: > >> The following reply was made to PR kern/181497; it has been noted by >> GNATS. >> >> From: Shawn Webb <lattera@gmail.com> >> To: bug-followup@FreeBSD.org, >> steven@roothosts.com >> >> Cc: >> Subject: Re: kern/181497: [kernel] [patch] Add ASLR feature to kernel >> Date: Tue, 4 Feb 2014 14:57:44 -0500 >> >> --Apple-Mail=3D_70D08D01-527F-4575-806A-36757E957E5A >> Content-Transfer-Encoding: quoted-printable >> Content-Type: text/plain; >> charset=3Dus-ascii >> >> I'm sorry, my patch actually wasn't right. It included other fixes I ha= d >> =3D >> in my branch for other features and didn't include some of the other = =3D >> ASLR bits. Attached is the right patch. >> >> > kernel compilation failed if configuration is "with PAX_ASLR options" and > "without COMPAT_FREEBSD32 options": > > --- kern_pax.o --- > /src/sys/kern/kern_pax.c:531:9: error: no member named > 'vm_aslr_delta_exec' in 'struct vmspace' > > vm->vm_aslr_delta_exec =3D round_page(PAX_ASLR_DELTA(arc4random(), > PAX_ASLR_DELTA_EXEC_LSB, (pr !=3D NULL) ? pr->pr_pax_aslr_exec_len : > pax_aslr_exec_len)); > ~~ ^ > 1 error generated. > > What's is this "vm_aslr_delta_exec" ? >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADt0fhxWeqkkjVrOG5B2gEN_3kfharkJXudEovVbj54%2BeBOckA>