Date: Wed, 5 Sep 2001 15:29:23 -0700 (PDT) From: "David E. Cross" <dec@FreeBSD.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/lib/libc/rpc svc_tcp.c svc_unix.c Message-ID: <200109052229.f85MTNJ32998@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
dec 2001/09/05 15:29:23 PDT
Modified files: (Branch: RELENG_4)
lib/libc/rpc svc_tcp.c svc_unix.c
Log:
Submitted by: <crossd@cs.rpi.edu>
Reviewed by: <re@freebsd.org>
Approved by: <re@freebsd.org>
Obtained from: <crossd@cs.rpi.edu>
MFC after: N/A, -CURRENT no longer uses this code
The patch in 1.28.2.1 was in error. It used FD_ZERO on the fds (fdset)
structure, but this is a dunamically allocated array that is only as
big as it needs to be. The result of calling FD_ZERO on it would be that
it would either overwrite random data in the data-segment, happen to
be just the right size and work correctly, or not zero out all of the
data it was supposed to. The first case is far more likely (and damaging).
This code has been in extensive testing here. And was approved by the
release engineers for this last minute push.
Revision Changes Path
1.18.2.3 +2 -2 src/lib/libc/rpc/Attic/svc_tcp.c
1.7.2.2 +2 -2 src/lib/libc/rpc/Attic/svc_unix.c
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200109052229.f85MTNJ32998>