Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 8 Sep 2021 08:53:33 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Adriaan de Groot <adridg@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: c04e85e180e5 - main - graphics/luminance-qt5: adjust Eigen dependency
Message-ID:  <YTh6DaYXsQA4RpRg@FreeBSD.org>
In-Reply-To: <2865178.slGk94SIus@beastie.bionicmutton.org>
References:  <202109080828.1888SmeA017351@gitrepo.freebsd.org> <YTh118W/v7kbpLXq@FreeBSD.org> <2865178.slGk94SIus@beastie.bionicmutton.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 08, 2021 at 10:49:45AM +0200, Adriaan de Groot wrote:
> On Wednesday, 8 September 2021 10:35:35 CEST Alexey Dokuchaev wrote:
> > This is wrong, I think you're confusing CMAKE_ON and
> > SOME_OPTION_CMAKE_ON.
> 
> You're right (and this reminds me how much I dislike the way our CMake
> magic-helpers are documented in the porter's handbook).

That's the reason why I avoid plain CMAKE_ON/OFF and always annotate
CMake's data types explicitly.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YTh6DaYXsQA4RpRg>