Date: Thu, 25 Oct 2001 16:12:51 -0700 From: Luigi Rizzo <luigi@FreeBSD.org> To: "Justin T. Gibbs" <gibbs@scsiguy.com> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_dcreg.h Message-ID: <20011025161251.J57392@iguana.aciri.org> In-Reply-To: <200110252306.f9PN62Y59798@aslan.scsiguy.com> References: <200110251743.f9PHhQ264466@freefall.freebsd.org> <200110252306.f9PN62Y59798@aslan.scsiguy.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 25, 2001 at 05:06:02PM -0600, Justin T. Gibbs wrote: > >luigi 2001/10/25 10:43:26 PDT > > > > Modified files: > > sys/pci if_dcreg.h > > Log: > > Defs for three (unused so far) bits in PCI command/status register > > were off by one bit. > > Shouldn't this driver just use the values in pcireg.h? possibly yes, but this is not my code, so i was merely fixing inconsistencies with the data sheets. Also, pcireg.h apparently is missing the definition for [the equivalent of] DC_CFCS_SYSERR_ENB, and seems to use 16-bit as opposed to 32-bit constants, so i can well understand why Bill redefined these constants on its own. cheers luigi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011025161251.J57392>