Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 28 Oct 2000 16:10:15 -0700 (PDT)
From:      Matthew Jacob <mjacob@feral.com>
To:        Mike Smith <msmith@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/pci pci.c
Message-ID:  <Pine.LNX.4.21.0010281609350.6685-100000@zeppo.feral.com>
In-Reply-To: <200010282307.QAA12200@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help



> msmith      2000/10/28 16:07:13 PDT
> 
>   Modified files:
>     sys/pci              pci.c 
>   Log:
>   Unconditionally turning on the I/O and memory enable bits in the PCI
>   command register is too aggressive.  Revert to the previous behaviour, but
>   leave the new behaviour available as an undocumented option.  It's not
>   clear what the Right, Right Thing is to do here, but the more conservative
>   approach is safer.

Uh, yeah. 

You should, IMO, let each platform decide how broken it's PCI implementations
are and have the core layers for them DTRT here.

-matt




To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.LNX.4.21.0010281609350.6685-100000>