Date: Sat, 11 Mar 2017 18:05:23 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Marcelo Araujo <araujo@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r315049 - head/usr.bin/vmstat Message-ID: <EB6AF0CB-D636-4D49-92C3-3374EDF6804E@gmail.com> In-Reply-To: <201703110436.v2B4aF6Z037011@repo.freebsd.org> References: <201703110436.v2B4aF6Z037011@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Mar 10, 2017, at 20:36, Marcelo Araujo <araujo@FreeBSD.org> wrote: > > Author: araujo > Date: Sat Mar 11 04:36:15 2017 > New Revision: 315049 > URL: https://svnweb.freebsd.org/changeset/base/315049 > > Log: > Bring back the cast removed in my previous commit to allow us build vmstat > with WARNS 2. This cast was first introduced at r87690. > > Reported by: bde, pfg and ngie > MFC after: 3 weeks. > > Modified: > head/usr.bin/vmstat/vmstat.c > > Modified: head/usr.bin/vmstat/vmstat.c > ============================================================================== > --- head/usr.bin/vmstat/vmstat.c Sat Mar 11 04:03:13 2017 (r315048) > +++ head/usr.bin/vmstat/vmstat.c Sat Mar 11 04:36:15 2017 (r315049) > @@ -288,13 +288,13 @@ retry_nlist: > namelist[X_SUM].n_name = "_cnt"; > goto retry_nlist; > } > - for (c = 0; c < nitems(namelist); c++) > + for (c = 0; c < (int)(nitems(namelist)); c++) Before bde@ notes this, it’s stylistically incorrect (additional unnecessary parentheses around the nitems call. Thanks, -Ngie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYxKzkAAoJEPWDqSZpMIYVIsIP/izalFLh6BHf/ZjsPiWc7F2e cGvkvLhQiWt/Ojc8FIWNml2JaCOTiDiCjmW1ii+JJA5pHh7dQv9z/+uGMZPRRWyv A67HQ7qDDPyRLNVhIEGmbHsp6bVBq7MTBducdOHTkoTTHLzyJkASqX4NtUhrrLbE md5awRhWLNugP6xWQdIP1T53FyedHc9rhuYoWlLtkuiGZ4ARe+BoTpIIBPnP4n1M 2jMJrAgWxdiXhpFPkkUbHRdTpXXW7dj9owm2uICUx29FbU+JhbOHpK4RU38rYRB4 imEQzajQkkAra7KenCGvyBLkosVsfS0Y9oSJ0gnZa3dtfBpaiUifJYryVXyXuy2/ UiLw3ZzZnkiABi8d6SMHiOl+0etNRP9ROEPc5af4RApsNLqrau4KO1hPR2FO7BDv MwUE6AF+wBe5Nr34Ic8c4rOe48i68GKi10Y5Y7RzB/KvZhgU+tMpust1K5w/J3R1 5tGiXTjF54PO7Lw8EGV3gocdrd+7W9ZM3rhD3NwJ23DKj1MGVQFTi0jJKclaZa99 g/c3DpOP3AiAHLxKXw7kbYMc5X9DQmAZcol5WnzWQv19rRklUKNbpLJeVw0ogSVl nPnA8z1aJyrHtInuzDZ/VqOWmWolCDmE1oAxRuHHsDMLSul+EtPpogunTiiCgkxc JrI4w+3ceQf9H+83n5LV =59ce -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EB6AF0CB-D636-4D49-92C3-3374EDF6804E>