Date: Sat, 29 Jul 2006 18:05:47 +0800 From: "Intron" <mag@intron.ac> To: Divacky Roman <xdivac02@stud.fit.vutbr.cz> Cc: alexander@leidinger.net, freebsd-emulation@freebsd.org Subject: [Updated on 2006-07-29] Re: My Linux AIO Implementation Calling for Test Message-ID: <1154167741.55639@origin.intron.ac> In-Reply-To: <20060728093647.GA32168@stud.fit.vutbr.cz> References: <1153994127.11460@origin.intron.ac> <20060728093647.GA32168@stud.fit.vutbr.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
Download: http://ftp.intron.ac/tmp/linux_aio-20060729.tar.bz2 1. Use LMSG(). 2. I wonder whether ARGS() is handy enough. Instead, the keyword __func__ instituted by ISO C99 should be used. See my DARGPRINTF(). 3. Some modifications for style(9). ------------------------------------------------------------------------ From Beijing, China Divacky Roman wrote: > On Thu, Jul 27, 2006 at 05:44:01PM +0800, Intron wrote: >> Download: http://ftp.intron.ac/tmp/linux_aio-20060727.tar.bz2 >> >> Based on FreeBSD aio(4), my patch set has implemented 5 system calls >> of Linux Asynchronous Input/Output: io_setup(2), io_destroy(2), >> io_getevents(2), io_submit(2) and io_cancel(2). It only works with >> 7.0-CURRENT. > > havent studied details but here are my suggestions: > > 1) please conform to style(9) > > 2) please use LMSG, ARGS macros to be conform with the rest of the linuxolator > > 3) why do you use uma directly? linuxolator uses malloc from within M_LINUX. I > personally dont mind using uma zone directly but if there is a reason for it. > > thnx for your contribution! > > roman
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1154167741.55639>