Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 16 May 2025 15:44:27 GMT
From:      Dag-Erling =?utf-8?Q?Sm=C3=B8rgrav?= <des@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 1518203b892f - main - libc: Improve scanfloat test.
Message-ID:  <202505161544.54GFiRct008635@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by des:

URL: https://cgit.FreeBSD.org/src/commit/?id=1518203b892f402fa72dd86a458a5d3a0b99dceb

commit 1518203b892f402fa72dd86a458a5d3a0b99dceb
Author:     Dag-Erling Smørgrav <des@FreeBSD.org>
AuthorDate: 2025-05-16 15:43:20 +0000
Commit:     Dag-Erling Smørgrav <des@FreeBSD.org>
CommitDate: 2025-05-16 15:44:10 +0000

    libc: Improve scanfloat test.
---
 lib/libc/tests/stdio/scanfloat_test.c | 136 +++++++++++++++++-----------------
 1 file changed, 68 insertions(+), 68 deletions(-)

diff --git a/lib/libc/tests/stdio/scanfloat_test.c b/lib/libc/tests/stdio/scanfloat_test.c
index a93238504dd1..635d93d560b3 100644
--- a/lib/libc/tests/stdio/scanfloat_test.c
+++ b/lib/libc/tests/stdio/scanfloat_test.c
@@ -59,88 +59,88 @@ ATF_TC_BODY(normalized_numbers, tc)
 	buf[0] = '\0';
 	ATF_REQUIRE(setlocale(LC_NUMERIC, ""));
 
-	sscanf("3.141592", "%e", &f);
+	ATF_REQUIRE_EQ(1, sscanf("3.141592", "%e", &f));
 	ATF_REQUIRE(eq(FLT, f, 3.141592));
 
-	sscanf("3.141592653589793", "%lf", &d);
+	ATF_REQUIRE_EQ(1, sscanf("3.141592653589793", "%lf", &d));
 	ATF_REQUIRE(eq(DBL, d, 3.141592653589793));
 
-	sscanf("1.234568e+06", "%E", &f);
+	ATF_REQUIRE_EQ(1, sscanf("1.234568e+06", "%E", &f));
 	ATF_REQUIRE(eq(FLT, f, 1.234568e+06));
 
-	sscanf("-1.234568e6", "%lF", &d);
+	ATF_REQUIRE_EQ(1, sscanf("-1.234568e6", "%lF", &d));
 	ATF_REQUIRE(eq(DBL, d, -1.234568e6));
 
-	sscanf("+1.234568e-52", "%LG", &ld);
+	ATF_REQUIRE_EQ(1, sscanf("+1.234568e-52", "%LG", &ld));
 	ATF_REQUIRE(eq(LDBL, ld, 1.234568e-52L));
 
-	sscanf("0.1", "%la", &d);
+	ATF_REQUIRE_EQ(1, sscanf("0.1", "%la", &d));
 	ATF_REQUIRE(eq(DBL, d, 0.1));
 
-	sscanf("00.2", "%lA", &d);
+	ATF_REQUIRE_EQ(1, sscanf("00.2", "%lA", &d));
 	ATF_REQUIRE(eq(DBL, d, 0.2));
 
-	sscanf("123456", "%5le%s", &d, buf);
+	ATF_REQUIRE_EQ(2, sscanf("123456", "%5le%s", &d, buf));
 	ATF_REQUIRE(eq(DBL, d, 12345.));
 	ATF_REQUIRE(strcmp(buf, "6") == 0);
 
-	sscanf("1.0Q", "%*5le%s", buf);
+	ATF_REQUIRE_EQ(1, sscanf("1.0Q", "%*5le%s", buf));
 	ATF_REQUIRE(strcmp(buf, "Q") == 0);
 
-	sscanf("-1.23e", "%e%s", &f, buf);
+	ATF_REQUIRE_EQ(2, sscanf("-1.23e", "%e%s", &f, buf));
 	ATF_REQUIRE(eq(FLT, f, -1.23));
 	ATF_REQUIRE(strcmp(buf, "e") == 0);
 
-	sscanf("1.25e+", "%le%s", &d, buf);
+	ATF_REQUIRE_EQ(2, sscanf("1.25e+", "%le%s", &d, buf));
 	ATF_REQUIRE(eq(DBL, d, 1.25));
 	ATF_REQUIRE(strcmp(buf, "e+") == 0);
 
-	sscanf("1.23E4E5", "%le%s", &d, buf);
+	ATF_REQUIRE_EQ(2, sscanf("1.23E4E5", "%le%s", &d, buf));
 	ATF_REQUIRE(eq(DBL, d, 1.23e4));
 	ATF_REQUIRE(strcmp(buf, "E5") == 0);
 
-	sscanf("12e6", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("12e6", "%le", &d));
 	ATF_REQUIRE(eq(DBL, d, 12e6));
 
-	sscanf("1.a", "%le%s", &d, buf);
+	ATF_REQUIRE_EQ(2, sscanf("1.a", "%le%s", &d, buf));
 	ATF_REQUIRE(eq(DBL, d, 1.0));
 	ATF_REQUIRE(strcmp(buf, "a") == 0);
 
-	sscanf(".0p4", "%le%s", &d, buf);
+	ATF_REQUIRE_EQ(2, sscanf(".0p4", "%le%s", &d, buf));
 	ATF_REQUIRE(eq(DBL, d, 0.0));
 	ATF_REQUIRE(strcmp(buf, "p4") == 0);
 
 	d = 0.25;
-	ATF_REQUIRE(sscanf(".", "%le", &d) == 0);
+	ATF_REQUIRE_EQ(0, sscanf(".", "%le", &d));
 	ATF_REQUIRE(d == 0.25);
 
-	sscanf("0x08", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("0x08", "%le", &d));
 	ATF_REQUIRE(d == 0x8p0);
 
-	sscanf("0x90a.bcdefP+09a", "%le%s", &d, buf);
+	ATF_REQUIRE_EQ(2, sscanf("0x90a.bcdefP+09a", "%le%s", &d, buf));
 	ATF_REQUIRE(d == 0x90a.bcdefp+09);
 	ATF_REQUIRE(strcmp(buf, "a") == 0);
 
 #if (LDBL_MANT_DIG > DBL_MANT_DIG) && !defined(__i386__)
-	sscanf("3.14159265358979323846", "%Lg", &ld);
+	ATF_REQUIRE_EQ(1, sscanf("3.14159265358979323846", "%Lg", &ld));
 	ATF_REQUIRE(eq(LDBL, ld, 3.14159265358979323846L));
 
-	sscanf("  0X.0123456789abcdefffp-3g", "%Le%s", &ld, buf);
+	ATF_REQUIRE_EQ(2, sscanf("  0X.0123456789abcdefffp-3g", "%Le%s", &ld, buf));
 	ATF_REQUIRE(ld == 0x0.0123456789abcdefffp-3L);
 	ATF_REQUIRE(strcmp(buf, "g") == 0);
 #endif
 
-	sscanf("0xg", "%le%s", &d, buf);
+	ATF_REQUIRE_EQ(2, sscanf("0xg", "%le%s", &d, buf));
 	ATF_REQUIRE(d == 0.0);
 	ATF_REQUIRE(strcmp(buf, "xg") == 0);
 
 	ATF_REQUIRE(setlocale(LC_NUMERIC, "ru_RU.ISO8859-5")); /* decimalpoint==, */
 
-	sscanf("1.23", "%le%s", &d, buf);
+	ATF_REQUIRE_EQ(2, sscanf("1.23", "%le%s", &d, buf));
 	ATF_REQUIRE(d == 1.0);
 	ATF_REQUIRE(strcmp(buf, ".23") == 0);
 
-	sscanf("1,23", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("1,23", "%le", &d));
 	ATF_REQUIRE(d == 1.23);
 
 	ATF_REQUIRE(setlocale(LC_NUMERIC, ""));
@@ -156,40 +156,40 @@ ATF_TC_BODY(infinities_and_nans, tc)
 
 	ATF_REQUIRE(setlocale(LC_NUMERIC, "C"));
 
-	sscanf("-Inf", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("-Inf", "%le", &d));
 	ATF_REQUIRE(d < 0.0 && isinf(d));
 
-	sscanf("iNfInItY and beyond", "%le%s", &d, buf);
+	ATF_REQUIRE_EQ(2, sscanf("iNfInItY and beyond", "%le%s", &d, buf));
 	ATF_REQUIRE(d > 0.0 && isinf(d));
 	ATF_REQUIRE(strcmp(buf, " and beyond"));
 
-	sscanf("NaN", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("NaN", "%le", &d));
 	ATF_REQUIRE(isnan(d));
 
-	sscanf("NAN(123Y", "%le%s", &d, buf);
+	ATF_REQUIRE_EQ(2, sscanf("NAN(123Y", "%le%s", &d, buf));
 	ATF_REQUIRE(isnan(d));
 	ATF_REQUIRE(strcmp(buf, "(123Y") == 0);
 
-	sscanf("nan(f00f)plugh", "%le%s", &d, buf);
+	ATF_REQUIRE_EQ(2, sscanf("nan(f00f)plugh", "%le%s", &d, buf));
 	ATF_REQUIRE(isnan(d));
 	ATF_REQUIRE(strcmp(buf, "plugh") == 0);
 
-	sscanf("-nan", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("-nan", "%le", &d));
 	ATF_REQUIRE(isnan(d));
 
 	/* Only quiet NaNs should be returned. */
-	sscanf("NaN", "%e", &f);
-	sscanf("nan", "%le", &d);
-	sscanf("nan", "%Le", &ld);
-	feclearexcept(FE_ALL_EXCEPT);
+	ATF_REQUIRE_EQ(1, sscanf("NaN", "%e", &f));
+	ATF_REQUIRE_EQ(1, sscanf("nan", "%le", &d));
+	ATF_REQUIRE_EQ(1, sscanf("nan", "%Le", &ld));
+	ATF_REQUIRE_EQ(0, feclearexcept(FE_ALL_EXCEPT));
 	ATF_REQUIRE(f != f);
 	ATF_REQUIRE(d != d);
 	ATF_REQUIRE(ld != ld);
 	ATF_REQUIRE(fetestexcept(FE_INVALID) == 0);
-	sscanf("nan(1234)", "%e", &f);
-	sscanf("nan(1234)", "%le", &d);
-	sscanf("nan(1234)", "%Le", &ld);
-	feclearexcept(FE_ALL_EXCEPT);
+	ATF_REQUIRE_EQ(1, sscanf("nan(1234)", "%e", &f));
+	ATF_REQUIRE_EQ(1, sscanf("nan(1234)", "%le", &d));
+	ATF_REQUIRE_EQ(1, sscanf("nan(1234)", "%Le", &ld));
+	ATF_REQUIRE_EQ(0, feclearexcept(FE_ALL_EXCEPT));
 	ATF_REQUIRE(f != f);
 	ATF_REQUIRE(d != d);
 	ATF_REQUIRE(ld != ld);
@@ -205,74 +205,74 @@ ATF_TC_BODY(rounding_tests, tc)
 
 	ATF_REQUIRE(setlocale(LC_NUMERIC, "C"));
 
-	fesetround(FE_DOWNWARD);
+	ATF_REQUIRE_EQ(0, fesetround(FE_DOWNWARD));
 
-	sscanf("1.999999999999999999999999999999999", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("1.999999999999999999999999999999999", "%le", &d));
 	ATF_REQUIRE(d < 2.0);
-	sscanf("0x1.ffffffffffffffp0", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("0x1.ffffffffffffffp0", "%le", &d));
 	ATF_REQUIRE(d < 2.0);
-	sscanf("1.999999999999999999999999999999999", "%Le", &ld);
+	ATF_REQUIRE_EQ(1, sscanf("1.999999999999999999999999999999999", "%Le", &ld));
 	ATF_REQUIRE(ld < 2.0);
 
-	sscanf("1.0571892669084007", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("1.0571892669084007", "%le", &d));
 	ATF_REQUIRE(d == 0x1.0ea3f4af0dc59p0);
-	sscanf("-1.0571892669084007", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("-1.0571892669084007", "%le", &d));
 	ATF_REQUIRE(d == -0x1.0ea3f4af0dc5ap0);
-	sscanf("1.0571892669084010", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("1.0571892669084010", "%le", &d));
 	ATF_REQUIRE(d == 0x1.0ea3f4af0dc5ap0);
 
-	sscanf("0x1.23p-5000", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("0x1.23p-5000", "%le", &d));
 	ATF_REQUIRE(d == 0.0);
 
-	sscanf("0x1.2345678p-1050", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("0x1.2345678p-1050", "%le", &d));
 	ATF_REQUIRE(d == 0x1.234567p-1050);
 
-	fesetround(FE_UPWARD);
+	ATF_REQUIRE_EQ(0, fesetround(FE_UPWARD));
 
-	sscanf("1.0571892669084007", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("1.0571892669084007", "%le", &d));
 	ATF_REQUIRE(d == 0x1.0ea3f4af0dc5ap0);
-	sscanf("-1.0571892669084007", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("-1.0571892669084007", "%le", &d));
 	ATF_REQUIRE(d == -0x1.0ea3f4af0dc59p0);
-	sscanf("1.0571892669084010", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("1.0571892669084010", "%le", &d));
 	ATF_REQUIRE(d == 0x1.0ea3f4af0dc5bp0);
 
-	sscanf("0x1.23p-5000", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("0x1.23p-5000", "%le", &d));
 	ATF_REQUIRE(d == 0x1p-1074);
 
-	sscanf("0x1.2345678p-1050", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("0x1.2345678p-1050", "%le", &d));
 	ATF_REQUIRE(d == 0x1.234568p-1050);
 
-	fesetround(FE_TOWARDZERO);
+	ATF_REQUIRE_EQ(0, fesetround(FE_TOWARDZERO));
 
-	sscanf("1.0571892669084007", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("1.0571892669084007", "%le", &d));
 	ATF_REQUIRE(d == 0x1.0ea3f4af0dc59p0);
-	sscanf("-1.0571892669084007", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("-1.0571892669084007", "%le", &d));
 	ATF_REQUIRE(d == -0x1.0ea3f4af0dc59p0);
-	sscanf("1.0571892669084010", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("1.0571892669084010", "%le", &d));
 	ATF_REQUIRE(d == 0x1.0ea3f4af0dc5ap0);
 
-	sscanf("0x1.23p-5000", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("0x1.23p-5000", "%le", &d));
 	ATF_REQUIRE(d == 0.0);
 
-	sscanf("0x1.2345678p-1050", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("0x1.2345678p-1050", "%le", &d));
 	ATF_REQUIRE(d == 0x1.234567p-1050);
 
-	fesetround(FE_TONEAREST);
+	ATF_REQUIRE_EQ(0, fesetround(FE_TONEAREST));
 
 	/* 1.0571892669084007 is slightly closer to 0x1.0ea3f4af0dc59p0 */
-	sscanf("1.0571892669084007", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("1.0571892669084007", "%le", &d));
 	ATF_REQUIRE(d == 0x1.0ea3f4af0dc59p0);
-	sscanf("-1.0571892669084007", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("-1.0571892669084007", "%le", &d));
 	ATF_REQUIRE(d == -0x1.0ea3f4af0dc59p0);
-	sscanf("1.0571892669084010", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("1.0571892669084010", "%le", &d));
 	ATF_REQUIRE(d == 0x1.0ea3f4af0dc5bp0);
 
 	/* strtod() should round small numbers to 0. */
-	sscanf("0x1.23p-5000", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("0x1.23p-5000", "%le", &d));
 	ATF_REQUIRE(d == 0.0);
 
 	/* Extra digits in a denormal shouldn't break anything. */
-	sscanf("0x1.2345678p-1050", "%le", &d);
+	ATF_REQUIRE_EQ(1, sscanf("0x1.2345678p-1050", "%le", &d));
 	ATF_REQUIRE(d == 0x1.234568p-1050);
 }
 
@@ -287,16 +287,16 @@ ATF_TC_BODY(strtod, tc)
 	ATF_REQUIRE(strcmp("xy", endp) == 0);
 
 	/* This used to cause an infinite loop and round the wrong way. */
-	fesetround(FE_DOWNWARD);
+	ATF_REQUIRE_EQ(0, fesetround(FE_DOWNWARD));
 	ATF_REQUIRE(strtof("3.5e38", &endp) == FLT_MAX);
 	ATF_REQUIRE(strtod("2e308", &endp) == DBL_MAX);
-	fesetround(FE_UPWARD);
+	ATF_REQUIRE_EQ(0, fesetround(FE_UPWARD));
 	ATF_REQUIRE(strtof("3.5e38", &endp) == INFINITY);
 	ATF_REQUIRE(strtod("2e308", &endp) == INFINITY);
-	fesetround(FE_TOWARDZERO);
+	ATF_REQUIRE_EQ(0, fesetround(FE_TOWARDZERO));
 	ATF_REQUIRE(strtof("3.5e38", &endp) == FLT_MAX);
 	ATF_REQUIRE(strtod("2e308", &endp) == DBL_MAX);
-	fesetround(FE_TONEAREST);
+	ATF_REQUIRE_EQ(0, fesetround(FE_TONEAREST));
 	ATF_REQUIRE(strtof("3.5e38", &endp) == INFINITY);
 	ATF_REQUIRE(strtod("2e308", &endp) == INFINITY);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202505161544.54GFiRct008635>