Date: Tue, 4 Apr 2017 08:55:13 -0500 From: Kyle Evans <kevans91@ksu.edu> To: Ed Maste <emaste@freebsd.org> Cc: Andrey Chernov <ache@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r316477 - head/usr.bin/grep Message-ID: <CACNAnaFXuh%2BXypOCi3L2jmCmhjx2DofVYja%2BTM_kexwZ5iiH_A@mail.gmail.com> In-Reply-To: <CAPyFy2Augn%2B1r41O%2B-uX5Vz8mwaPK5LZMj5Geij-61cb-MSxfA@mail.gmail.com> References: <201704032316.v33NGpbo037305@repo.freebsd.org> <4ceb1a18-3a72-c0e3-b2e2-f71d687cd153@freebsd.org> <CACNAnaGMv0WGO0MjnJwrYTdZhutoU7qPbzkiCS2zi2wnCKV=ZQ@mail.gmail.com> <9018c8db-2a89-c8b2-750b-fe11ac08333f@freebsd.org> <CACNAnaH3LQZZ03gDE6DDAGrKQSmbWo3m=e5h247LpxmbkB74TQ@mail.gmail.com> <CAPyFy2Augn%2B1r41O%2B-uX5Vz8mwaPK5LZMj5Geij-61cb-MSxfA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Apr 4, 2017 at 8:53 AM, Ed Maste <emaste@freebsd.org> wrote:
> In this case I'd rather we remove the 00 and have the test verify
> that. I think it's fine if there are a few tests that fail when run
> with GNU grep where it has the undesired, differing behaviour.
>
Excellent- can you please revert this entire bit then:
@@ -474,13 +509,13 @@ printline(struct str *line, int sep, reg
fwrite(line->dat + a, matches[i].rm_so - a,
1,
stdout);
if (color)
- fprintf(stdout, "\33[%sm\33[K", color);
+ fprintf(stdout, "\33[%sm", color);
fwrite(line->dat + matches[i].rm_so,
matches[i].rm_eo - matches[i].rm_so, 1,
stdout);
if (color)
- fprintf(stdout, "\33[m\33[K");
+ fprintf(stdout, "\33[00m\33[K");
a = matches[i].rm_eo;
if (oflag)
putchar('\n');
I'll address this in the unit tests review shortly.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaFXuh%2BXypOCi3L2jmCmhjx2DofVYja%2BTM_kexwZ5iiH_A>