Date: Mon, 3 May 2004 00:25:30 -0700 From: David Schultz <das@FreeBSD.ORG> To: "David O'Brien" <obrien@FreeBSD.ORG> Cc: Tim Robbins <tjr@FreeBSD.ORG> Subject: Re: cvs commit: src/lib/libc/stdio vfwscanf.c Message-ID: <20040503072530.GA14247@VARK.homeunix.com> In-Reply-To: <20040503060649.GA1773@dragon.nuxi.com> References: <200405022013.i42KDTk1064157@repoman.freebsd.org> <20040503035654.GA93315@cat.robbins.dropbear.id.au> <20040503060649.GA1773@dragon.nuxi.com>
index | next in thread | previous in thread | raw e-mail
On Sun, May 02, 2004, David O'Brien wrote: > On Mon, May 03, 2004 at 01:56:54PM +1000, Tim Robbins wrote: > > On Sun, May 02, 2004 at 01:13:29PM -0700, David E. O'Brien wrote: > > > > > obrien 2004/05/02 13:13:29 PDT > > > > > > FreeBSD src repository > > > > > > Modified files: > > > lib/libc/stdio vfwscanf.c > > > Log: > > > Remove bogus FBSDID. > > > > These weren't bogus -- they showed the revision of the single-byte version > > that the files corresponded to, so that it was easy to see which changes > > needed to be merged across. > > One shouldn't have duplicate __FBSDID()'s. To do what you wanted to do, > one should grab the CVS info and put it in the file header comment > section prefixed with "From: ". :-) Moreover, if you put it in a /*-style comment, people like me won't break the build as a result of cut-and-paste-o's that happen after merging and testing. Whups. Thanks for fixing it, David. Personally, I'd actually prefer that the second set of tags stay deleted. I don't know how easy they are to manage with P4, but they're a PITA to do manually with CVS. The CVS logs ought to be sufficient to see what changes need to be merged, without having the extra tag.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040503072530.GA14247>