Date: Wed, 09 May 2018 15:05:43 -0600 From: Ian Lepore <ian@freebsd.org> To: Mariusz Zaborski <oshogbo@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333438 - head/sbin/geom/class/eli Message-ID: <1525899943.35372.42.camel@freebsd.org> In-Reply-To: <201805092051.w49KpGZm079239@repo.freebsd.org> References: <201805092051.w49KpGZm079239@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 2018-05-09 at 20:51 +0000, Mariusz Zaborski wrote: > Author: oshogbo > Date: Wed May 9 20:51:16 2018 > New Revision: 333438 > URL: https://svnweb.freebsd.org/changeset/base/333438 > > Log: > Change option dry-run from 'n' to 'C' in geli attach command. > > 'n' is used in other commands to define the key index. > We should be consistent with that. > 'C' option is used by patch(1) to perform dryrun so lets use that. This seems like a dangerous change. Today I am begining to write new product image creation scripts that involve geli, and I'm going to do so under the assumption that the commands and arguments are not going to suddenly change their meaning on some future OS update. Hopefully the new meaning of -n implies an argument which is validated as being either 0 or 1, so that any existing scripts that contain -n to mean "dry run" will very likely fail the validation and not silently misbehave. At the very least, it seems like an entry in UPDATING is required. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1525899943.35372.42.camel>