Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 12 Nov 2022 18:42:54 +0100 (CET)
From:      freebsd@oldach.net (Helge Oldach)
To:        jhb@FreeBSD.org (John Baldwin)
Cc:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   Re: git: 5ae69e2f10da - stable/13 - Import the WireGuard driver from zx2c4.com.
Message-ID:  <202211121742.2ACHgstj040466@nuc.oldach.net>
In-Reply-To: <202211112204.2ABM4KYW005382@gitrepo.freebsd.org> from John Baldwin at "11 Nov 2022 22:04:20"

next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote on Fri, 11 Nov 2022 23:04:20 +0100 (CET):
> The branch stable/13 has been updated by jhb:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=5ae69e2f10dacd750b0f0e9284fefcbe97eb0476
> 
> commit 5ae69e2f10dacd750b0f0e9284fefcbe97eb0476
> Author:     John Baldwin <jhb@FreeBSD.org>
> AuthorDate: 2022-10-28 20:36:12 +0000
> Commit:     John Baldwin <jhb@FreeBSD.org>
> CommitDate: 2022-11-11 21:44:11 +0000
> 
>     Import the WireGuard driver from zx2c4.com.

Is perhaps an #include <sys/proc.h> missing in if_wg.c?

I'm getting below error on stable/13-n252920-0baacb12181. After manually adding said header include, it compiles cleanly.

--- modules-all ---
--- if_wg.o ---
/usr/src/sys/dev/wg/if_wg.c:2741:17: error: implicit declaration of function 'crhold' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        sc->sc_ucred = crhold(curthread->td_ucred);
                       ^
/usr/src/sys/dev/wg/if_wg.c:2741:33: error: incomplete definition of type 'struct thread'
        sc->sc_ucred = crhold(curthread->td_ucred);
                              ~~~~~~~~~^
/usr/src/sys/sys/sockbuf.h:73:8: note: forward declaration of 'struct thread'
struct thread;
       ^
/usr/src/sys/dev/wg/if_wg.c:2742:37: error: incomplete definition of type 'struct thread'
        sc->sc_socket.so_fibnum = curthread->td_proc->p_fibnum;
                                  ~~~~~~~~~^
/usr/src/sys/sys/sockbuf.h:73:8: note: forward declaration of 'struct thread'
struct thread;
       ^
/usr/src/sys/dev/wg/if_wg.c:2869:3: error: implicit declaration of function 'crfree' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                crfree(cred);
                ^
/usr/src/sys/dev/wg/if_wg.c:2945:66: error: incomplete definition of type 'struct ucred'
                if (!(sc->sc_flags & WGF_DYING) && sc->sc_ucred && sc->sc_ucred->cr_prison == pr) {
                                                                   ~~~~~~~~~~~~^
/usr/src/sys/sys/systm.h:131:8: note: forward declaration of 'struct ucred'
struct ucred;
       ^
/usr/src/sys/dev/wg/if_wg.c:2951:4: error: implicit declaration of function 'crfree' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                        crfree(cred);
                        ^
6 errors generated.
*** [modules-all] Error code 6

make[2]: stopped in /usr/obj/usr/src/amd64.amd64/sys/HMO

Kind regards
Helge



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202211121742.2ACHgstj040466>