Date: Sat, 4 Feb 2006 01:11:03 +0100 From: Max Laier <max@love2party.net> To: "Devon H. O'Dell" <dodell@ixsystems.com> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Robert Watson <rwatson@freebsd.org>, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/security/audit audit_arg.c Message-ID: <200602040111.12261.max@love2party.net> In-Reply-To: <20060203155613.J41267@knight.iXsystems.com> References: <200602032350.k13NoQ1c047653@repoman.freebsd.org> <20060203155613.J41267@knight.iXsystems.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Saturday 04 February 2006 00:56, Devon H. O'Dell wrote: > On Fri, Feb 03, 2006 at 11:50:26PM +0000, Robert Watson wrote: > > rwatson 2006-02-03 23:50:26 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/security/audit audit_arg.c > > Log: > > Fix INVARIANTS build on amd64; (unsigned unsigned long) != u_int64_t. > > Not to be pedantic or rude or anything, but don't we use > uint64_t these days? And shouldn't we use %ju for printing > these types? As this is somewhat vendor code, I think u_int64_t is okay. As for %ju, I think it's stupid. I even believe that %llu shouldn't raise an error when printing unsigned integers with sizeof(arg_type) == sizeof(long long) - this should be possible as a compile time assert in whatever code is responsible for this. We are seeing this type of porting problem over and over again, there should be a better sollution. -- /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBD4/EgXyyEoT62BG0RAnkuAJ4mvyyOPt5B/PIWD3hjv8wsKve3HwCfdZBu 0+IAfQaiHpAojb99IUqsdzE= =U864 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200602040111.12261.max>