Date: Wed, 23 Aug 2023 12:48:08 +0530 From: Sumit Saxena <sumit.saxena@broadcom.com> To: Warner Losh <imp@bsdimp.com> Cc: Kevin Bowling <kevin.bowling@kev009.com>, Kristof Provost <kp@freebsd.org>, Warner Losh <imp@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org>, src-committers <src-committers@freebsd.org>, Chandrakanth Patil <chandrakanth.patil@broadcom.com> Subject: Re: git: 91fcacc35597 - main - if_bnxt: Add support for VLAN on Thor Message-ID: <CAL2rwxqBXqgXMdc3Wge85cE-%2BgQrK=XrZDD1p5QjAr5oeoX6GA@mail.gmail.com> In-Reply-To: <CANCZdfr6fkKPLVA2JAHiSJSsJj9-tQbFGuK%2BPj2JsEZ24qRENw@mail.gmail.com> References: <202211042255.2A4MtqVv032693@gitrepo.freebsd.org> <419530F4-DB8F-46EA-BF45-C130BCF8A3DE@FreeBSD.org> <05979953-C089-4D56-99E3-BBBF066FE277@FreeBSD.org> <CAK7dMtCJhwpV96znB4if48FtWEy091ss-nmvMp5zoLUvtkAs%2BA@mail.gmail.com> <CAK7dMtA6FL%2BCzw9Z2TC2-N0cA=WshDBsEVam0__ift9VfFrq7Q@mail.gmail.com> <CANCZdfrO7gJDsnUu465CN96V4eWowtD-eqH2340u1-Yo14F4_w@mail.gmail.com> <CANCZdfr6fkKPLVA2JAHiSJSsJj9-tQbFGuK%2BPj2JsEZ24qRENw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000082bdad060391eb42 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable +Chandrakanth Patil Chandrakanth is working on this bug. -Sumit On Wed, Aug 23, 2023 at 6:01=E2=80=AFAM Warner Losh <imp@bsdimp.com> wrote: > > > > On Tue, Aug 22, 2023, 6:26 PM Warner Losh <imp@bsdimp.com> wrote: >> >> >> >> On Tue, Aug 22, 2023, 5:59 PM Kevin Bowling <kevin.bowling@kev009.com> w= rote: >>> >>> On Tue, Aug 22, 2023 at 3:39=E2=80=AFPM Kevin Bowling <kevin.bowling@ke= v009.com> wrote: >>> > >>> > >>> > >>> > On Tue, Aug 22, 2023 at 2:07 PM Kristof Provost <kp@freebsd.org> wrot= e: >>> >> >>> >> On 27 Jun 2023, at 11:17, Kristof Provost wrote: >>> >> >>> >> On 4 Nov 2022, at 23:55, Warner Losh wrote: >>> >> >>> >> The branch main has been updated by imp: >>> >> >>> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D91fcacc355971f74aa26f= c7861020dc3a2a2d717 >>> >> >>> >> commit 91fcacc355971f74aa26fc7861020dc3a2a2d717 >>> >> Author: Sumit Saxena <sumit.saxena@broadcom.com> >>> >> AuthorDate: 2022-11-04 22:24:32 +0000 >>> >> Commit: Warner Losh <imp@FreeBSD.org> >>> >> CommitDate: 2022-11-04 22:24:32 +0000 >>> >> >>> >> if_bnxt: Add support for VLAN on Thor >>> >> >>> >> Reviewed by: imp >>> >> Differential Revision: https://reviews.freebsd.org/D36443 >>> >> --- >>> >> sys/dev/bnxt/bnxt.h | 3 +- >>> >> sys/dev/bnxt/bnxt_hwrm.c | 110 ++++++++++++++++++++++++++++---------= ---------- >>> >> sys/dev/bnxt/bnxt_hwrm.h | 7 ++- >>> >> sys/dev/bnxt/if_bnxt.c | 7 ++- >>> >> 4 files changed, 74 insertions(+), 53 deletions(-) >>> >> >>> >> This commit appears to have broken vlan on these interfaces. >>> >> My hardware is a Broadcom BCM57416 NetXtreme-E 10GBase-T Ethernet, (= in a Dell T640, if that helps). >>> >> >>> >> A simple vlan creation on top of one: >>> >> ifconfig vlan create >>> >> ifconfig vlan0 vlan 201 vlandev bnxt0 >>> >> >>> >> Results in a loss of connectivity. The kernel logs this, which I ass= ume is related: >>> >> >>> >> `bnxt0: HWRM_CFA_L2_FILTER_ALLOC command returned INVALID_PARAMS err= or.` >>> >> >>> >> After reverting this (and 72e9dbb58cad5262190cf2eae47f764021072128) = I can create vlan interfaces on top of bnxt0 without losing connectivity. >>> >> >>> >> >>> >> Should we revert this before 14.0? >>> >> >>> >> There=E2=80=99s also a report of what I think is the same issue in h= ttps://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269133 >>> >> >>> >> There=E2=80=99s a proposed patch there, but it did not work for me. >>> > >>> > >>> > In markj=E2=80=99s analysis he mentions the issue of the reinit. >>> > >>> > It sounds like there are multiple bugs in this driver but one quick b= and aid may be to mark the driver as not needing re-init for VLAN modificat= ions.. that sounds unlikely and was probably an accident when the if reset = functionality was added. You can check e1000 for that. >>> >>> Here's what I mean as a patch https://reviews.freebsd.org/D41558 >>> >>> > Note I don=E2=80=99t have this hw and haven=E2=80=99t audited the cod= e so this could be noise but it=E2=80=99s an easy thing to check. >> >> >> Is there a good bug we can post that link to for someone to test? > > > Duh.. posted to bug above and > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D222680 > > Warner > >> >> Warner >>> >>> > >>> >> Best regards, >>> >> Kristof --00000000000082bdad060391eb42 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQbQYJKoZIhvcNAQcCoIIQXjCCEFoCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3EMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBUwwggQ0oAMCAQICDB2B69csh2jp9sI0jzANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAwOTE1MzVaFw0yNTA5MTAwOTE1MzVaMIGO MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xFTATBgNVBAMTDFN1bWl0IFNheGVuYTEoMCYGCSqGSIb3DQEJ ARYZc3VtaXQuc2F4ZW5hQGJyb2FkY29tLmNvbTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoC ggEBALoGydo8plkxTqXV8MOi06PQvWWLx02gZEgN0QNCmUbBNjDUSFh3ONINOfWPHBGHm7xAZwkv 4t5gJ0bMkTp/mTSrDsXyD6voKaTveYz6fDPfzcb+NvqXiDHmYnxR1h2BJ3N37GR8/gMG9J4H9Uny hExFVC4t1YMhXlpVGcRlHPt/nMF8z9sE9vd7z2HFKhRfIQ7eChsb4fv7Qb6gYdK7eMHs2EEeyY1W 1J8x62/iEVbCstJaE1Nt3oXnL5yBlqX1Ihp8cZLe1weS7Wp/v5Jg2Ks13jeYOKW45xXExpqPPd1f 3meFjTf9K+rGZHb63htWaJtf0NYbE+5yIbXFv21cBxECAwEAAaOCAdowggHWMA4GA1UdDwEB/wQE AwIFoDCBowYIKwYBBQUHAQEEgZYwgZMwTgYIKwYBBQUHMAKGQmh0dHA6Ly9zZWN1cmUuZ2xvYmFs c2lnbi5jb20vY2FjZXJ0L2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNydDBBBggrBgEFBQcw AYY1aHR0cDovL29jc3AuZ2xvYmFsc2lnbi5jb20vZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAw TQYDVR0gBEYwRDBCBgorBgEEAaAyASgKMDQwMgYIKwYBBQUHAgEWJmh0dHBzOi8vd3d3Lmdsb2Jh bHNpZ24uY29tL3JlcG9zaXRvcnkvMAkGA1UdEwQCMAAwSQYDVR0fBEIwQDA+oDygOoY4aHR0cDov L2NybC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWduMmNhMjAyMC5jcmwwJAYDVR0R BB0wG4EZc3VtaXQuc2F4ZW5hQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEFBQcDBDAfBgNV HSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUTIFIrhFDaoMEbXuV9O+Y+XgS kVwwDQYJKoZIhvcNAQELBQADggEBAFyioHqB2PHWcQ5cU8nprPRk37uSWK2x0w7W50jjc0cooz6G G6pltJ+DvbG7XIzCU8cKHmuyAxoe1+/vhB8yJH78MVdfKDDND7zL/IqfhZedxHcHG5jVqbVH/ufu H19y4fHxo5bLkybX3UxkN9b3bMsBZ4FFCLSCFgFfjI0BmTx6IoGyi0R89rzD0H1rURy7WTn0ijl1 nERsqENeyGfUTJLcDSURb49qpFqqWweJ7ifC64Iak8wCK2CxCe8lHfTyEgC9MuEa586NMQJDguvw jlC7kxrgwf4sZ/9Wj/GS2HLzZPkxWCcQIrgNJm2wceHQwPBpM0ZoqL1D2tsFgOA8BvYxggJtMIIC aQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQD EyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwdgevXLIdo6fbCNI8w DQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIB2Np5Cgm2An9t9mOB82QxQ5X0IcxSYZ DANcoc8vnIBFMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTIzMDgy MzA3MTgzNlowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUDBAEWMAsGCWCG SAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsGCWCGSAFlAwQC ATANBgkqhkiG9w0BAQEFAASCAQCFADAZhycjINuPHF3n1Nv42XMLTrm8QaRUxnlENXbKgJtdmXHW l0KF2Tou94j2SjvOqyGXGCpRPI2eGSf/ZQhfatHV3By+a202L+s1CJz6l7gPlkJPQZ8u1eTgU3SP zOvrXuKaZY7CkIejTIvCHWwp32nrcvlfli7TVtDXRohbNEmo3pUUIFEQDH5GlwRJzGjX1OhMS4qr swgyG/0jtNmhY2TrrQFZyBX8lg3AYQDiRGjIbTrUip/z3m5aqUehENnLkZfglvY4yDwJwnb+KW9T 3DczDgIVJ31/VNpa+EjrPH/CEVTMoFK9YGWJYyffLP2hACe4qVGZDzA5XG+32s1W --00000000000082bdad060391eb42--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAL2rwxqBXqgXMdc3Wge85cE-%2BgQrK=XrZDD1p5QjAr5oeoX6GA>