Date: Sat, 14 Jun 2008 00:07:26 +0200 From: Marcin Cieslak <saper@SYSTEM.PL> To: Edwin Groothuis <edwin@mavetju.org> Cc: cvs-ports@FreeBSD.org, "QA Tindy \(Ion-Mihai Tetcu\)" <itetcu@FreeBSD.org>, Mark Linimon <linimon@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/security/fwknop Makefile Message-ID: <4852EF9E.1020802@SYSTEM.PL> In-Reply-To: <20080613214419.GA89632@k7.mavetju> References: <200806131120.m5DBKDIW037834@repoman.freebsd.org> <20080613142924.03e8495a@it.buh.tecnik93.com> <4852ADA0.9010100@SYSTEM.PL> <20080613214419.GA89632@k7.mavetju>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Edwin Groothuis wrote:
> I understand the moving to BUILD_DEPNDS, but I don't understand the
> killing of the RUN_DEPENDS.
>
> I will do it for now, but you might want to rethink it (he said
> without any knowledge of Java or the application itself)
Well actually we need both. They are required both at the build as well
as at the run time. Probably we could introduce something like
JAR_DEPENDS= for java ports that would be similar in LIB_DEPENDS but
depending on .jar files.
For now we need both like in jakarta-commons-httpclient/Makefile for
example.
Something like this should do then:
cvs diff: Diffing .
Index: Makefile
===================================================================
RCS file: /usr/home/ncvs/ports/net/tn5250j/Makefile,v
retrieving revision 1.1
diff -u -u -r1.1 Makefile
--- Makefile 13 Jun 2008 02:37:00 -0000 1.1
+++ Makefile 13 Jun 2008 22:06:49 -0000
@@ -17,9 +17,10 @@
BUILD_DEPENDS= ${JAVAJARDIR}/mail.jar:${PORTSDIR}/java/javamail \
${JYTHON_JAR}:${PORTSDIR}/lang/jython \
- ${JAVAJARDIR}/jt400.jar:${PORTSDIR}/sysutils/jtopen
-RUN_DEPENDS= ${JAVAJARDIR}/itext.jar:${PORTSDIR}/devel/itext \
+ ${JAVAJARDIR}/jt400.jar:${PORTSDIR}/sysutils/jtopen \
+ ${JAVAJARDIR}/itext.jar:${PORTSDIR}/devel/itext \
${JAVAJARDIR}/log4j.jar:${PORTSDIR}/devel/log4j
+RUN_DEPENDS= ${BUILD_DEPENDS}
USE_ZIP= yes
USE_ANT= yes
--
<< Marcin Cieslak // saper@system.pl >>
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
iQCVAwUBSFLvoT2W2v2wY27ZAQNjcgP/ZXwk5hMwkzpXP2ZC0Uxwq7dtBmIH8jNr
H6Lr9esC9CRIvuxJym/Ds3Huk7HsyynwXPqyiwr0GLjYMQN5sGZ9khY6dKXnaswo
AIZHTsSr3TgvY1pwIyCDa1W1wTtd/sf9Tm2zYJT1PqFMt4ZLWrgsL7v2NiUn55A/
/Dgt8476yQs=
=MVbS
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4852EF9E.1020802>