Date: Wed, 22 May 2019 12:49:19 -0400 From: Mark Johnston <markj@freebsd.org> To: rgrimes@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r348090 - in head/libexec/bootpd: . bootpgw Message-ID: <20190522164919.GC5125@spy> In-Reply-To: <201905221548.x4MFmAIF085473@gndrsh.dnsmgr.net> References: <20190522151116.GB5125@spy> <201905221548.x4MFmAIF085473@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, May 22, 2019 at 08:48:10AM -0700, Rodney W. Grimes wrote: > > On Tue, May 21, 2019 at 09:25:23PM -0700, Rodney W. Grimes wrote: > > To be honest I have no desire to spend more time on bootpd than I > > already have. You are welcome to improve the usage formatting if > > you like. > > omg, really? Old "folke lore" You touched, you own it. I own plenty of things already. > If I didnt have to go through bde and/or phk I would of just gone > and commited the clean up. Ok, that's something for you to figure out. > I have handed you the diff. > > Perhaps a phab review before would of made this less painfull. > And perhaps a phab review once an issue had been raised would > of been really less painful. There was a phab review for the original change, and I fixed an issue that was introduced by that change. I think that's sufficient.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190522164919.GC5125>