Date: Tue, 23 Nov 2010 01:08:01 +0200 From: Alexander Motin <mav@FreeBSD.org> To: Artem Belevich <fbsdlist@src.cx> Cc: Bruce Cran <bruce@cran.org.uk>, Alexander Best <arundel@freebsd.org>, freebsd-hackers@freebsd.org Subject: Re: Another small error. Re: Logical vs. bitwise AND in sbin/routed/parms.c Message-ID: <4CEAF7D1.8050505@FreeBSD.org> In-Reply-To: <AANLkTi=TZa1pPaMAof0ZJTVG-%2B5VwsQc0bQz%2BDg5-9TF@mail.gmail.com> References: <AANLkTi=TZa1pPaMAof0ZJTVG-%2B5VwsQc0bQz%2BDg5-9TF@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 23.11.2010 00:07, Artem Belevich wrote: > While it's not directly related to hunting for '&'/'&&' typos, here's > another seemingly wrong place in the code: > > --- a/sys/dev/ahci/ahci.c > +++ b/sys/dev/ahci/ahci.c > @@ -852,7 +852,7 @@ ahci_ch_attach(device_t dev) > ch->caps = ctlr->caps; > ch->caps2 = ctlr->caps2; > ch->quirks = ctlr->quirks; > - ch->numslots = ((ch->caps& AHCI_CAP_NCS)>> AHCI_CAP_NCS_SHIFT) + 1, > + ch->numslots = ((ch->caps& AHCI_CAP_NCS)>> AHCI_CAP_NCS_SHIFT) + 1; > mtx_init(&ch->mtx, "AHCI channel lock", NULL, MTX_DEF); > resource_int_value(device_get_name(dev), > device_get_unit(dev), "pm_level",&ch->pm_level); > > I did mention it on freebsd-current@ some time back: > http://lists.freebsd.org/pipermail/freebsd-current/2009-November/013645.html Fixed at r215725. Thanks. -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4CEAF7D1.8050505>