Date: Thu, 17 Jan 2019 13:45:36 -0800 From: Conrad Meyer <cem@freebsd.org> To: Eugene Grosbein <eugen@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343118 - in head/usr.sbin: . trim Message-ID: <CAG6CVpXzqj2Qg0jRwFB7t6xnbLQZ_uLcPZ=rSfAJYE-t4vSHYw@mail.gmail.com> In-Reply-To: <2d239dc0-915c-2d2b-0936-a40af5e9ead9@freebsd.org> References: <201901171808.x0HI80jC068564@repo.freebsd.org> <CAG6CVpVBsFDgksLEWG_U%2B4k6tH3SnaZkNFgd77D8NfLDf21Pdg@mail.gmail.com> <2d239dc0-915c-2d2b-0936-a40af5e9ead9@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 17, 2019 at 1:16 PM Eugene Grosbein <eugen@freebsd.org> wrote: > > 18.01.2019 3:23, Conrad Meyer =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > > Please back it out; stop attributing code review to "hackers@," which > > can not (it's a list, not individuals) and did not review this > > changeset; and put it on phabricator for actual review. > > There is already https://reviews.freebsd.org/D18380 by imp > and there were over 6 weeks since it had an update. > Newly committed code has most of its changes. Your response does not address *any* of the above concerns. It's just unrelated. The review you linked to isn't one you submitted for this change; it's Warner's, and that one stalled because you were such a jerk to him last time that he needed time off from you. If you want to socialize, revive, or expedite someone else's review, maybe add a new comment to the review, or post a discussion hackers@, or something like that. You still can't attribute code review to hackers@, especially as no such review happened. Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpXzqj2Qg0jRwFB7t6xnbLQZ_uLcPZ=rSfAJYE-t4vSHYw>